You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/01/19 13:26:49 UTC
[GitHub] [incubator-brpc] zyearn opened a new pull request #1032:
replace_include_with_find_package
zyearn opened a new pull request #1032: replace_include_with_find_package
URL: https://github.com/apache/incubator-brpc/pull/1032
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on issue #1032:
replace_include_with_find_package
Posted by GitBox <gi...@apache.org>.
zyearn commented on issue #1032: replace_include_with_find_package
URL: https://github.com/apache/incubator-brpc/pull/1032#issuecomment-576128661
cmake/FindGFLAGS.cmake and cmake/FindGperftools.cmake can not be deleted because they are not builtin module of cmake, we still need it if user install them using other method, such as apt-get
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on issue #1032:
replace_include_with_find_package
Posted by GitBox <gi...@apache.org>.
zyearn commented on issue #1032: replace_include_with_find_package
URL: https://github.com/apache/incubator-brpc/pull/1032#issuecomment-576091247
according to https://github.com/apache/incubator-brpc/issues/1023, find_package provide more options for user to set(such as CMAKE_PREFIX_PATH). The minimum cmake version that brpc use is [2.8.10](https://cmake.org/cmake/help/v2.8.10/cmake.html#command:find_package), and find_package is supported in this version. It is safe to replace include with find_package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] jamesge merged pull request #1032:
replace_include_with_find_package
Posted by GitBox <gi...@apache.org>.
jamesge merged pull request #1032: replace_include_with_find_package
URL: https://github.com/apache/incubator-brpc/pull/1032
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org