[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2512: Remove remaining uses of `binary_array_op_scalar!` in binary.rs

[GitBox <gi...@apache.org>]

alamb commented on code in PR #2512:
URL: https://github.com/apache/arrow-datafusion/pull/2512#discussion_r870302946


##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -1142,6 +1079,20 @@ macro_rules! binary_array_op_dyn_scalar {
     }}
 }
 
+/// Compares the array with the scalar value for equality, sometimes
+/// used in other kernels
+pub(crate) fn array_eq_scalar(lhs: &dyn Array, rhs: &ScalarValue) -> Result<ArrayRef> {

Review Comment:
   I made a function to call `binary_array_op_dyn_scalar!` from `null_if` rather than having it call the macro directly to clean that code up. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org