[GitHub] [ignite] AMashenkov commented on a change in pull request #9314: IGNITE-15281 add cluster state check into statistics manager.

[GitBox <gi...@apache.org>]

AMashenkov commented on a change in pull request #9314:
URL: https://github.com/apache/ignite/pull/9314#discussion_r704164450



##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteStatisticsConfigurationManager.java
##########
@@ -241,50 +241,11 @@ public IgniteStatisticsConfigurationManager(
 
         this.subscriptionProcessor.registerDistributedMetastorageListener(distrMetaStoreLsnr);
 
+        ColumnConfigurationViewSupplier colCfgViewSupplier = new ColumnConfigurationViewSupplier(this,
+            logSupplier);
         sysViewMgr.registerFiltrableView(STAT_CFG_VIEW_NAME, STAT_CFG_VIEW_DESCRIPTION,
-            new StatisticsColumnConfigurationViewWalker(), this::columnConfigurationViewSupplier, Function.identity());
-    }
-
-    /**
-     * Statistics column configuration view filterable supplier.
-     *
-     * @param filter Filter.
-     * @return Iterable with selected statistics column configuration views.
-     */
-    private Iterable<StatisticsColumnConfigurationView> columnConfigurationViewSupplier(Map<String, Object> filter) {
-        String schema = (String)filter.get(StatisticsColumnConfigurationViewWalker.SCHEMA_FILTER);
-        String name = (String)filter.get(StatisticsColumnConfigurationViewWalker.NAME_FILTER);
-
-        Collection<StatisticsObjectConfiguration> configs;
-        try {
-            if (!F.isEmpty(schema) && !F.isEmpty(name)) {
-                StatisticsKey key = new StatisticsKey(schema, name);
-                StatisticsObjectConfiguration keyCfg = config(key);
-
-                if (keyCfg == null)
-                    return Collections.emptyList();
-
-                configs = Collections.singletonList(keyCfg);
-            }
-            else
-                configs = getAllConfig();
-        }
-        catch (IgniteCheckedException e) {
-            log.warning("Error while getting statistics configuration: " + e.getMessage(), e);
-
-            configs = Collections.emptyList();
-        }
-
-        List<StatisticsColumnConfigurationView> res = new ArrayList<>();
-
-        for (StatisticsObjectConfiguration cfg : configs) {
-            for (StatisticsColumnConfiguration colCfg : cfg.columnsAll().values()) {
-                if (!colCfg.tombstone())
-                    res.add(new StatisticsColumnConfigurationView(cfg, colCfg));
-            }
-        }
-
-        return res;
+            new StatisticsColumnConfigurationViewWalker(), colCfgViewSupplier::columnConfigurationViewSupplier,
+            Function.identity());

Review comment:
       ```suggestion
               new StatisticsColumnConfigurationViewWalker(), 
               colCfgViewSupplier::columnConfigurationViewSupplier,
               Function.identity());
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org