You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by gemmellr <gi...@git.apache.org> on 2018/10/16 14:24:26 UTC

[GitHub] qpid-proton-j pull request #18: NO-JIRA Minor code improvements (e.g. semico...

Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/qpid-proton-j/pull/18#discussion_r225562577
  
    --- Diff: examples/reactor/src/main/java/org/apache/qpid/proton/example/reactor/EchoInputStreamWrapper.java ---
    @@ -31,11 +31,12 @@
     
     public class EchoInputStreamWrapper extends Thread {
     
    +    private static final AtomicInteger idCounter = new AtomicInteger();
    --- End diff --
    
    I'd actually be more inclined to delete the example (since its crap) than think about it any more than I have already hehe. Either way, the change should not have been moved to the other PR since it isn't part of that issue.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org