You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/18 09:44:09 UTC

[GitHub] [apisix] zhendongcmss commented on pull request #6256: feat(error-log-logger): add clickhouse for error-log-logger

zhendongcmss commented on pull request #6256:
URL: https://github.com/apache/apisix/pull/6256#issuecomment-1044229651


   > Now that we have the clickhouse plugin, can we implement it in this plugin?
   > 
   > I am concerned that this will introduce duplicate code.
   
   I think it is a good idea. One side we can reduce duplicate code, antoher avoid `error-log-logger.lua` oversize. It is friendly for new plugin.
   
   @spacewander How about you ？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org