You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "cqzhang7 (via GitHub)" <gi...@apache.org> on 2023/09/18 10:09:38 UTC
[GitHub] [iotdb] cqzhang7 opened a new pull request, #11171: [Bug] Support group by natural year #11133
cqzhang7 opened a new pull request, #11171:
URL: https://github.com/apache/iotdb/pull/11171
由于group by基于年时有闰年的情况，修改后更符合语义
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] cqzhang7 commented on pull request #11171: [Bug] Support group by natural year #11133
Posted by "cqzhang7 (via GitHub)" <gi...@apache.org>.
cqzhang7 commented on PR #11171:
URL: https://github.com/apache/iotdb/pull/11171#issuecomment-1727358489
Thanks for the guidance. I'll try to do more to resolve it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] cqzhang7 closed pull request #11171: [Bug] Support group by natural year #11133
Posted by "cqzhang7 (via GitHub)" <gi...@apache.org>.
cqzhang7 closed pull request #11171: [Bug] Support group by natural year #11133
URL: https://github.com/apache/iotdb/pull/11171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #11171: [Bug] Support group by natural year #11133
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on PR #11171:
URL: https://github.com/apache/iotdb/pull/11171#issuecomment-1727164556
This PR is not complete. You may need to check GroupByMonthFilter class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org