You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/20 01:40:37 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #10368: CI Images are now pre-build and stored in registry

mik-laj commented on a change in pull request #10368:
URL: https://github.com/apache/airflow/pull/10368#discussion_r473518461



##########
File path: scripts/ci/images/ci_prepare_ci_image_on_ci.sh
##########
@@ -18,4 +18,59 @@
 # shellcheck source=scripts/ci/libraries/_script_init.sh
 . "$( dirname "${BASH_SOURCE[0]}" )/../libraries/_script_init.sh"
 
+# In case GITHUB_REGISTRY_PULL_IMAGE_TAG is different than latest, tries to pull the image indefinitely
+# skips further image checks - assuming that this is the right image
+function wait_for_ci_image_tag {

Review comment:
       This function looks very similar to ``wait_for_prod_images_tag``? Is it on purpose? Is it possible to get rid of this repetitive code?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org