You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/10/01 06:14:15 UTC

[GitHub] [myfaces] milansie opened a new pull request, #327: MYFACES-4445: websockets refactoring

milansie opened a new pull request, #327:
URL: https://github.com/apache/myfaces/pull/327

   - reworked channel token generation - new token is generated only if needed (ie new session/view), just one token for application scope
   - fixed usage of user-specified channel - now also works even in application scope calls
   - changed default max idle timeout for websockets - according to omnifaces/mojarra spec
   - specified default websocket scope - according to documentation (session scope for user-specified websocket as default)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] melloware merged pull request #327: MYFACES-4445: websockets refactoring

Posted by GitBox <gi...@apache.org>.
melloware merged PR #327:
URL: https://github.com/apache/myfaces/pull/327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] melloware commented on pull request #327: MYFACES-4445: websockets refactoring

Posted by GitBox <gi...@apache.org>.
melloware commented on PR #327:
URL: https://github.com/apache/myfaces/pull/327#issuecomment-1269933200

   These look good to me I am going to merge this and @milansie you can work on the 4.0 changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] milansie commented on pull request #327: MYFACES-4445: websockets refactoring

Posted by GitBox <gi...@apache.org>.
milansie commented on PR #327:
URL: https://github.com/apache/myfaces/pull/327#issuecomment-1269616835

   i'm ready to port the changes to version 4.0 as soon as the changes are confirmed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org