[GitHub] [echarts] anymos commented on issue #17342: [Bug] Float64Array can not be used in a dataset unless the X is converted to an array: const x = Array.from(new Float64Array([1,2,3,4,5,6,7,8,9,10]));

[GitBox <gi...@apache.org>]

anymos commented on issue #17342:
URL: https://github.com/apache/echarts/issues/17342#issuecomment-1181312020

   Hi @plainheart , thank you to come back to me that quick, it's really cool.
   
   I agree that the current source code do not handle that case with dataset as a row (regular array with typed arrays)
   Meanwhile the work around that you propose could work for small data set, it get in a way of huge data set in the form of typeArray.
   
   An exemple to illustrate this with a time series from financial, it is  lot easier to manage typeArray extends by concatenating them using binary copy when the dataset are in row with [[time][price][etc ...] than using a one dimension array,. 
   
   With a one time dimension array you can not add a new variable easily as you have to recompute the full one dimension array to add them inside for each of them.
   
   Beside, with one dimension array, you need to keep only one typed array Float64 or int64 , with multiple dimension you can have [float64,int64, etc ...]
   
   Which is more optimal from a RAM perspective.
   
   In my use case there is millions of records and it impact the RAM quite a bit.
   
   In understand that it is maybe not a priority, and I am not too sure of the complexity involved to make this happens.
   
   I let you judge you know a lot better than me the underlying code and dependency.
   
   In the mean time, thank you again for your time to read and review that ticket.
   
   Have a good day moving forward ! 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org