You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/05/02 14:34:19 UTC

[GitHub] khos2ow commented on a change in pull request #2616: 4.11.1.0: Stabilization and blocker/issues fixes

khos2ow commented on a change in pull request #2616: 4.11.1.0: Stabilization and blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#discussion_r185515379
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
 ##########
 @@ -71,16 +71,16 @@ config_guest() {
 
 get_boot_params() {
   case $HYPERVISOR in
-     xen-pv)
+     xen-pv|xen-domU)
 
 Review comment:
   @rhtyd you should not add `xen-domU` to this case, because in fully patched Xenserver one HVM instance might be reported as `xen-domU` which in reality is should be `xen-hvm`. Basically this is the output of `virt-what`.
   I'll put another comment to describe further.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services