You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/24 16:42:49 UTC

[PR] Remove SingletonSPI on DeliverEventSubscriber [shardingsphere]

terrymanu opened a new pull request, #39953:
URL: https://github.com/apache/shardingsphere/pull/39953

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove SingletonSPI on DeliverEventSubscriber [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39953:
URL: https://github.com/apache/shardingsphere/pull/39953#issuecomment-5818337183

   Result
   Review Result: Mergeable
   Fixed the risk of event subscribers using the wrong repository. The Cluster builder already obtains, injects, and registers subscribers each time it builds a context. Removing the incorrect singleton annotation lets the loader provide a separate instance for each build.
   Evidence
   - The new regression test uses two event buses and repositories. After B is registered, it posts an event to A and verifies that the operation uses A’s repository. Both tests passed.
   - The existing Cluster builder tests passed: 3 tests.
   - Spotless and Checkstyle passed for both changed files. Checkstyle was confirmed to include the production file.
   Coverage
   Standalone local candidate; baseline 3ace7771a76. Reviewed only the SPI interface in mode/core and the subscriber test in features/readwrite-splitting/core. Checked the root cause, SPI lifecycle, affected call paths, compatibility, and regression coverage; no unresolved blockers remain. This conclusion covers local code only; CI was not reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove SingletonSPI on DeliverEventSubscriber [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39953:
URL: https://github.com/apache/shardingsphere/pull/39953#issuecomment-5818271389

   Do not need code review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove SingletonSPI on DeliverEventSubscriber [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39953:
URL: https://github.com/apache/shardingsphere/pull/39953


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org