[jira] [Commented] (MCHANGES-354) The plugin should fail to execute if the changes.xml file cannot be parsed

["Karl Heinz Marbaise (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MCHANGES-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586531#comment-14586531 ] 

Karl Heinz Marbaise commented on MCHANGES-354:
----------------------------------------------

Maybe i mistaken something or what ever ...but when i try to apply your patch on the current trunk...it does not change anything...Can you please recheck the patch and how you have created...Have you created it on command line or via IDE ?
{code}
maven-changes-plugin$ svn patch MCHANGES-354-maven-changes-plugin.patch
maven-changes-plugin$ svn st
?       MCHANGES-354-maven-changes-plugin.patch
{code}
Can you created it by {{svn diff >x.patch}} ?

> The plugin should fail to execute if the changes.xml file cannot be parsed
> --------------------------------------------------------------------------
>
>                 Key: MCHANGES-354
>                 URL: https://issues.apache.org/jira/browse/MCHANGES-354
>             Project: Maven Changes Plugin
>          Issue Type: Bug
>            Reporter: Gabor Szabo
>         Attachments: MCHANGES-354-maven-changes-plugin.patch
>
>
> Currently if there is a problem during changes.xml parsing, the exception is caught and logged, but the changes-report goal is executed successfully.
> This is misleading as from the result it seems everything was fine, however a fatal error occurred.
> There is also a FIXME comment here that suggests an exception should be thrown: https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesXML.java (line 101)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)