You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/03/13 20:33:27 UTC

[GitHub] matthiasblaesing closed pull request #419: [NETBEANS-408] Fix AntJUnitManagerProviderTest test at junit.ant.ui module.

matthiasblaesing closed pull request #419: [NETBEANS-408] Fix AntJUnitManagerProviderTest test at junit.ant.ui module.
URL: https://github.com/apache/incubator-netbeans/pull/419
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/junit.ant.ui/test/unit/src/org/netbeans/modules/junit/ant/ui/AntJUnitManagerProviderTest.java b/junit.ant.ui/test/unit/src/org/netbeans/modules/junit/ant/ui/AntJUnitManagerProviderTest.java
index f927cc049..293a9b98e 100644
--- a/junit.ant.ui/test/unit/src/org/netbeans/modules/junit/ant/ui/AntJUnitManagerProviderTest.java
+++ b/junit.ant.ui/test/unit/src/org/netbeans/modules/junit/ant/ui/AntJUnitManagerProviderTest.java
@@ -25,6 +25,8 @@
 import org.junit.BeforeClass;
 import org.junit.Test;
 import static org.junit.Assert.*;
+import org.netbeans.modules.gsf.testrunner.ui.api.Manager;
+import org.netbeans.modules.gsf.testrunner.ui.api.TestRunnerNodeFactory;
 
 /**
  *
@@ -56,11 +58,11 @@ public void tearDown() {
      */
     @Test
     public void testRegisterNodeFactory() {
-        System.out.println("registerNodeFactory");
         AntJUnitManagerProvider instance = new AntJUnitManagerProvider();
         instance.registerNodeFactory();
-        // TODO review the generated test code and remove the default call to fail.
-        fail("The test case is a prototype.");
+        TestRunnerNodeFactory nodeFactory = Manager.getInstance().getNodeFactory();
+        assertNotNull(nodeFactory);
+        assertTrue(AntJUnitTestRunnerNodeFactory.class.isAssignableFrom(nodeFactory.getClass()));
     }
     
 }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists