[jira] [Commented] (YETUS-538) set capacity on ArrayList init where possible

["Yetus QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151639#comment-16151639 ] 

Yetus QA commented on YETUS-538:
--------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 12m 56s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m  0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  0s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m  0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m  0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m  0s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m  0s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/yetus:ca562e8 |
| JIRA Issue | YETUS-538 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12885106/YETUS-538.00.patch |
| Optional Tests |  javac  compile  javadoc  |
| uname | Linux 45703ce26bf9 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / d5ca095 |
| Default Java | 1.8.0_131 |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/619/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> set capacity on ArrayList init where possible
> ---------------------------------------------
>
>                 Key: YETUS-538
>                 URL: https://issues.apache.org/jira/browse/YETUS-538
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Audience Annotations
>    Affects Versions: 0.4.0, 0.5.0
>            Reporter: Sean Busbey
>            Assignee: Peter Cseh
>            Priority: Minor
>              Labels: beginner
>         Attachments: YETUS-538.00.patch
>
>
> we have one case of not giving the ArrayList constructor an initial capacity
> {code}
> Busbey-MBA:yetus busbey$ git grep "new ArrayList"
> audience-annotations-component/audience-annotations/src/main/java/org/apache/yetus/audience/tools/RootDocProcessor.java:      List<Object> list = new ArrayList<Object>(array.length);
> audience-annotations-component/audience-annotations/src/main/java/org/apache/yetus/audience/tools/StabilityOptions.java:    List<String[]> optionsList = new ArrayList<String[]>();
> Busbey-MBA:yetus busbey$ 
> {code}
> {{StabilityOptions}} should be updated to use {{options.length}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)