You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/18 13:45:16 UTC
[GitHub] [mynewt-nimble] sjanc opened a new pull request #917: Mesh build fix
sjanc opened a new pull request #917:
URL: https://github.com/apache/mynewt-nimble/pull/917
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #917: Mesh build fix
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #917:
URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781912294
with CDB off I get linker error, with CDB on indeed there is build error. So none is working without it if settings are enabled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #917: Mesh build fix
Posted by GitBox <gi...@apache.org>.
KKopyscinski commented on pull request #917:
URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781356479
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #917: Mesh build fix
Posted by GitBox <gi...@apache.org>.
KKopyscinski commented on pull request #917:
URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781863772
@sjanc I checked it again and CDB is off by default; this fixes issue when CDB is on. Could you change commit title?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski removed a comment on pull request #917: Mesh build fix
Posted by GitBox <gi...@apache.org>.
KKopyscinski removed a comment on pull request #917:
URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781912770
What app is not compiling with CDB off then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #917: Mesh build fix
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #917:
URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781354720
<!-- style-bot -->
## Style check fail: Payload was too large
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #917: Mesh build fix
Posted by GitBox <gi...@apache.org>.
KKopyscinski commented on pull request #917:
URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781912770
What app is not compiling with CDB off then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #917: Mesh build fix
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #917:
URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781354720
<!-- style-bot -->
## Style check fail: Payload was too large
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #917: Mesh build fix
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #917:
URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781390945
<!-- style-bot -->
## Style check fail: Payload was too large
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #917: Mesh build fix
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #917:
URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781910017
Hmm this is what I see in syscfg.yml for mesh:
BLE_MESH_CDB:
description: >
Mesh Configuration Database [EXPERIMENTAL]
value: 0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc removed a comment on pull request #917: Mesh build fix
Posted by GitBox <gi...@apache.org>.
sjanc removed a comment on pull request #917:
URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781910017
Hmm this is what I see in syscfg.yml for mesh:
BLE_MESH_CDB:
description: >
Mesh Configuration Database [EXPERIMENTAL]
value: 0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc merged pull request #917: Mesh build fix
Posted by GitBox <gi...@apache.org>.
sjanc merged pull request #917:
URL: https://github.com/apache/mynewt-nimble/pull/917
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org