[GitHub] [airflow] potiuk edited a comment on issue #13513: Switch external actions to subrepo'ed .github/actions/

[GitBox <gi...@apache.org>]

potiuk edited a comment on issue #13513:
URL: https://github.com/apache/airflow/issues/13513#issuecomment-755261879


   CC: @kaxil @ashb @turbaszek @TobKed -> WDYT ? I think this is much better approach than the cloned repositories we have now.
   
   Maybe @TobKed  you would like to take a stab on it ? Happy to help as I've done it several times and know subrepo ins-outs very well.
   
   Also anticipating comments about "yet another tool" - > subrepo is great because it does not require ANY action from the users of the repositories that are brought in. Unlike submodule, it does not require any change of the worklfow (when you checkout the repo the code for the repo just appears there. From the repository point of view, this is just a single, usually squashed commit where you commit the subrepo, with all the new code included, plus a single file (.subrepo I think) where subrepo records the URL of the original repo + commit hash/branch it was copied from. The only worlflows that require subrepo are:
   
   a) when you want to update to newer version of the repo
   b) when you want to upstream local change
   
   And we worked out and documented that workflows nicely in one of the projects we worked on so we can bring the "step-by-step" instructions easily. 
   
   The nicest thing about this approach is that:
   
   a) You see the code of the action in your repo, so you can easier find out what's wrong if there are some problems
   b) You can easily make modification to those actions in your PR and they can be tested in much simpler workflow (just modify code in your PR as opposed to:
      1. modify action
      2. hope that it works
      3. change hash commit
      4. update PR ). 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org