[jira] Commented: (MATH-260) Inconsistent API in Frequency

["Luc Maisonobe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MATH-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794711#action_12794711 ] 

Luc Maisonobe commented on MATH-260:
------------------------------------

Note: the addValue(Object) has been deprecated as of 2.0 and replaced by addValue(Comparable).
I think we could also deprecate or even remove addValue(Integer) since addValue(Comparable) is sufficient for all purposes. Removing the method would probably not harm any users if they can recompile their code (but it would harm if they cannot recompile, of course).

> Inconsistent API in Frequency
> -----------------------------
>
>                 Key: MATH-260
>                 URL: https://issues.apache.org/jira/browse/MATH-260
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Sebb
>            Priority: Minor
>
> The overloaded Frequency methods are not consistent in the parameter types that they handle.
> addValue() has an Integer version which converts the parameter to a Long, and then calls addValue(Object).
> The various getxxx() methods all handle Integer parameters as an Object.
> Seems to me that it would be better to treat Integer consistently.
> But perhaps there is a good reason for having an addValue(Integer) method but no getxxx(Integer) methods?
> If so, then it would be helpful to document this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.