You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Cédric Chantepie (JIRA)" <ji...@apache.org> on 2011/03/11 16:16:59 UTC
[jira] Created: (SSHD-114) Session listener
Session listener
----------------
Key: SSHD-114
URL: https://issues.apache.org/jira/browse/SSHD-114
Project: MINA SSHD
Issue Type: Improvement
Reporter: Cédric Chantepie
Fix For: 0.5.0
Allow to add listener for major event (such as when |close| method is fired) about SSH Session instance.
Currently I've worked around by implementing my own SessionFactory, which itself return custom Session instances supporting such listener.
With a listener on standard/provided Session instance may not require user to to do such custom implementations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SSHD-114) Session listener
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SSHD-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved SSHD-114.
----------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.5.0)
0.6.0
Assignee: Guillaume Nodet
Thx for the patch Cédric.
> Session listener
> ----------------
>
> Key: SSHD-114
> URL: https://issues.apache.org/jira/browse/SSHD-114
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Cédric Chantepie
> Assignee: Guillaume Nodet
> Labels: listener, session
> Fix For: 0.6.0
>
> Attachments: slistener.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Allow to add listener for major event (such as when |close| method is fired) about SSH Session instance.
> Currently I've worked around by implementing my own SessionFactory, which itself return custom Session instances supporting such listener.
> With a listener on standard/provided Session instance may not require user to to do such custom implementations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SSHD-114) Session listener
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SSHD-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015855#comment-13015855 ]
Guillaume Nodet commented on SSHD-114:
--------------------------------------
Hi Cédric,
While reviewing this patch, it occured to me that it may be better to add the listeners for sessions at a upper level so that the listeners could be informed when sessions are created. I think that would be more symetric and would allow a single listener to be registered instead of having to register it for each session.
> Session listener
> ----------------
>
> Key: SSHD-114
> URL: https://issues.apache.org/jira/browse/SSHD-114
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Cédric Chantepie
> Labels: listener, session
> Fix For: 0.5.0
>
> Attachments: slistener.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Allow to add listener for major event (such as when |close| method is fired) about SSH Session instance.
> Currently I've worked around by implementing my own SessionFactory, which itself return custom Session instances supporting such listener.
> With a listener on standard/provided Session instance may not require user to to do such custom implementations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SSHD-114) Session listener
Posted by "Bernd Fondermann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SSHD-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005717#comment-13005717 ]
Bernd Fondermann commented on SSHD-114:
---------------------------------------
Cédric, do you want to contribute a patch?
> Session listener
> ----------------
>
> Key: SSHD-114
> URL: https://issues.apache.org/jira/browse/SSHD-114
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Cédric Chantepie
> Labels: listener, session
> Fix For: 0.5.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Allow to add listener for major event (such as when |close| method is fired) about SSH Session instance.
> Currently I've worked around by implementing my own SessionFactory, which itself return custom Session instances supporting such listener.
> With a listener on standard/provided Session instance may not require user to to do such custom implementations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SSHD-114) Session listener
Posted by "Cédric Chantepie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SSHD-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015890#comment-13015890 ]
Cédric Chantepie commented on SSHD-114:
---------------------------------------
In current patch, listeners are also added at SessionFactory level. As far as I understand it could match your expectation.
As for listeners at Session level, I have thought that some people would prefer to "monitor" not all session but just some of them.
It could be removed if no one think it could be useful.
> Session listener
> ----------------
>
> Key: SSHD-114
> URL: https://issues.apache.org/jira/browse/SSHD-114
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Cédric Chantepie
> Labels: listener, session
> Fix For: 0.5.0
>
> Attachments: slistener.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Allow to add listener for major event (such as when |close| method is fired) about SSH Session instance.
> Currently I've worked around by implementing my own SessionFactory, which itself return custom Session instances supporting such listener.
> With a listener on standard/provided Session instance may not require user to to do such custom implementations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SSHD-114) Session listener
Posted by "Cédric Chantepie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SSHD-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cédric Chantepie updated SSHD-114:
----------------------------------
Attachment: slistener.patch
Quick patch
> Session listener
> ----------------
>
> Key: SSHD-114
> URL: https://issues.apache.org/jira/browse/SSHD-114
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Cédric Chantepie
> Labels: listener, session
> Fix For: 0.5.0
>
> Attachments: slistener.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Allow to add listener for major event (such as when |close| method is fired) about SSH Session instance.
> Currently I've worked around by implementing my own SessionFactory, which itself return custom Session instances supporting such listener.
> With a listener on standard/provided Session instance may not require user to to do such custom implementations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SSHD-114) Session listener
Posted by "Cédric Chantepie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SSHD-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005728#comment-13005728 ]
Cédric Chantepie commented on SSHD-114:
---------------------------------------
I can try
> Session listener
> ----------------
>
> Key: SSHD-114
> URL: https://issues.apache.org/jira/browse/SSHD-114
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Cédric Chantepie
> Labels: listener, session
> Fix For: 0.5.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Allow to add listener for major event (such as when |close| method is fired) about SSH Session instance.
> Currently I've worked around by implementing my own SessionFactory, which itself return custom Session instances supporting such listener.
> With a listener on standard/provided Session instance may not require user to to do such custom implementations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira