[jira] [Commented] (IGNITE-896) Configuration inconsistency

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582772#comment-16582772 ] 

ASF GitHub Bot commented on IGNITE-896:
---------------------------------------

GitHub user zzzadruga opened a pull request:

    https://github.com/apache/ignite/pull/4561

    IGNITE-896 Configuration inconsistency

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zzzadruga/ignite IGNITE-896

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4561.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4561
    
----
commit 39226745ce2a620d34efe31b5bcbd54508786375
Author: zzzadruga <zz...@...>
Date:   2018-08-14T17:06:22Z

    IGNITE-896 Add evictionFilterFactory field, getter and setter. Mark evictionFilter as @deprecated.

commit 93eaaccabdc8c778969cfb20dc3bdf60699fb7df
Author: zzzadruga <zz...@...>
Date:   2018-08-14T17:08:33Z

    IGNITE-896 Add Factory for IgfsEvictionFilter

commit 43e4696603e863b668eeb683e62fb5046a34ce1d
Author: zzzadruga <zz...@...>
Date:   2018-08-14T17:10:23Z

    IGNITE-896 Refactor IgfsHelper

commit bf7697d1b13d3e22f5fa284a08ed4dd9ce74bf1b
Author: zzzadruga <zz...@...>
Date:   2018-08-14T17:11:56Z

    IGNITE-896 Refactor GridCacheEvictionManager

commit ed38c977801d7b3fa2da3d69d9c8a329dad9ca93
Author: Nikolai Kulagin <zz...@...>
Date:   2018-08-15T12:10:48Z

    IGNITE-896 Add topValidatorFactory field, getter and setter. Mark topValidator as @deprecated

commit c31db024012bd9a3dacb3294397a0a277909d1e8
Author: Nikolai Kulagin <zz...@...>
Date:   2018-08-16T12:36:34Z

    IGNITE-896 Fix some tests

commit f0119237cbcdcc4001fecd1cf2aafb782c26e475
Author: Nikolai Kulagin <zz...@...>
Date:   2018-08-16T12:58:25Z

    IGNITE-896 Fix CacheGroupContext

commit 97894930038b9c007238cb4af0ecae056f117173
Author: Nikolai Kulagin <zz...@...>
Date:   2018-08-16T13:02:12Z

    IGNITE-896 Apply patch [IGNITE-9005, PR 4373] + fix for evictionFilterFactory

commit d56bb7ad893cdd5a70b1059f36fcd7a96d8b9928
Author: Nikolai Kulagin <zz...@...>
Date:   2018-08-16T13:08:49Z

    IGNITE-896 Fix GridCacheAttributes

commit a2731af7475281fabe2289a18a1ee1db26aa3111
Author: Nikolai Kulagin <zz...@...>
Date:   2018-08-16T13:11:16Z

    IGNITE-896 Fix VisorCacheConfiguration

commit d21485da5d05fe2872563ab8af3680f4dc6b3510
Author: Nikolai Kulagin <zz...@...>
Date:   2018-08-16T13:20:35Z

    IGNITE-896 Fix ConfigVariations

commit bee2788441dddc0b07f00b03ad32ccc210413b7c
Author: Nikolai Kulagin <zz...@...>
Date:   2018-08-16T15:52:29Z

    IGNITE-896 Add serialVersionUID in IgfsEvictionFilterFactory

commit 485eb16340a8aaef162e391f652d95d5399868d7
Author: Nikolai Kulagin <zz...@...>
Date:   2018-08-16T15:53:02Z

    IGNITE-896 Fix ClusterCachesInfo

----


> Configuration inconsistency
> ---------------------------
>
>                 Key: IGNITE-896
>                 URL: https://issues.apache.org/jira/browse/IGNITE-896
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>    Affects Versions: sprint-5
>            Reporter: Valentin Kulichenko
>            Assignee: Nikolai Kulagin
>            Priority: Minor
>              Labels: Usability
>
> I noticed that some entities on cache configuration are configured via factories, while others are set directly. For example, we use factory for ExpiryPolicy, but not for EvictionPolicy, which looks inconsistent. Since factory-based approach comes from JCache, I think we should use it wherever possible.
> Here is the list of settings that need to be fixed:
> * Affinity
> * AffinityMapper
> * EvictionFilter
> * EvictionPolicy
> * CacheInterceptor
> * TopologyValidator
> Need to add new configuration properties that use factories and deprecate old ones (do not remove for compatibility).
> Also need to check other configuration beans (list above is for cache config only).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)