You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/12/06 18:43:43 UTC
Review Request 54432: Added os::unsetCloexec to stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54432/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
Added os::unsetCloexec to stout.
Diffs
-----
3rdparty/stout/include/stout/os/posix/fcntl.hpp daaca0da959b8ad04bc5042b85e5b9e3e6653344
3rdparty/stout/include/stout/os/windows/fcntl.hpp 2bc794a405e59d80c1e8308c0049d2306347adfa
3rdparty/stout/tests/os_tests.cpp 446282373aebb06dae32209a9b0d148cb15eced9
Diff: https://reviews.apache.org/r/54432/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 54432: Added os::unsetCloexec to stout.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54432/#review158273
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Dec. 6, 2016, 6:43 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54432/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 6:43 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added os::unsetCloexec to stout.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/fcntl.hpp daaca0da959b8ad04bc5042b85e5b9e3e6653344
> 3rdparty/stout/include/stout/os/windows/fcntl.hpp 2bc794a405e59d80c1e8308c0049d2306347adfa
> 3rdparty/stout/tests/os_tests.cpp 446282373aebb06dae32209a9b0d148cb15eced9
>
> Diff: https://reviews.apache.org/r/54432/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>