You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/12 20:04:01 UTC

[GitHub] [maven-filtering] sebthom commented on a change in pull request #15: [MRESOURCES-268] - Report path of offending file on copy/filter error.

sebthom commented on a change in pull request #15:
URL: https://github.com/apache/maven-filtering/pull/15#discussion_r556049602



##########
File path: src/main/java/org/apache/maven/shared/filtering/DefaultMavenFileFilter.java
##########
@@ -110,7 +110,8 @@ public void copyFile( File from, File to, boolean filtering, List<FileUtils.Filt
         }
         catch ( IOException e )
         {
-            throw new MavenFilteringException( e.getMessage(), e );
+            throw new MavenFilteringException( ( filtering ? "filtering " : "copying " ) + from.getPath() + " to "

Review comment:
       What do you mean with duplicate information? When maven-resources-plugin currently fails, it only displays a cryptic error message like `[ERROR] Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:3.2.0:resources (default-resources) on project test: Input length = 1 -> [Help 1]` without **any** context information. Even when using `mvn -e` the displayed stacktrace does not show any information about the file that failed during the operation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org