[GitHub] [lucene] rmuir commented on issue #12000: Lucene-facet leaves ThreadLocal that creates a memory leak

[GitBox <gi...@apache.org>]

rmuir commented on issue #12000:
URL: https://github.com/apache/lucene/issues/12000#issuecomment-1341271839

   Thanks @gvaysman-at-github for reporting this. I was unaware of this threadlocal, indeed it looks problematic just from the description in this cache:
   
   ```
   /** A "cache" that never frees memory, and stores labels in a BytesRefHash (utf-8 encoding). */
   public final class UTF8TaxonomyWriterCache implements TaxonomyWriterCache, Accountable {
     private final ThreadLocal<BytesRefBuilder> bytes =
         new ThreadLocal<BytesRefBuilder>() {
           @Override
           protected BytesRefBuilder initialValue() {
             return new BytesRefBuilder();
           }
         };
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org