You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2023/01/05 10:04:51 UTC
[GitHub] [shardingsphere] FlyingZC opened a new pull request, #23352: Fix failed to start when both have XA and BASE dependencies(#23351)
FlyingZC opened a new pull request, #23352:
URL: https://github.com/apache/shardingsphere/pull/23352
Fixes #23351.
Changes proposed in this pull request:
- Fix failed to start when both have XA and BASE dependencies
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] FlyingZC commented on pull request #23352: Fix failed to start when both have XA and BASE dependencies(#23351)
Posted by GitBox <gi...@apache.org>.
FlyingZC commented on PR #23352:
URL: https://github.com/apache/shardingsphere/pull/23352#issuecomment-1375100212
> The transaction type is pluggable, please write them with static way
Ok, I will design more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] FlyingZC closed pull request #23352: Fix failed to start when both have XA and BASE dependencies(#23351)
Posted by GitBox <gi...@apache.org>.
FlyingZC closed pull request #23352: Fix failed to start when both have XA and BASE dependencies(#23351)
URL: https://github.com/apache/shardingsphere/pull/23352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23352: Fix failed to start when both have XA and BASE dependencies(#23351)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23352:
URL: https://github.com/apache/shardingsphere/pull/23352#issuecomment-1376693147
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23352?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23352](https://codecov.io/gh/apache/shardingsphere/pull/23352?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d36023) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a2f1014ca63364d547defbb7b19e187983ad5f95?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a2f1014) will **increase** coverage by `0.06%`.
> The diff coverage is `60.00%`.
```diff
@@ Coverage Diff @@
## master #23352 +/- ##
============================================
+ Coverage 49.82% 49.89% +0.06%
- Complexity 2461 2486 +25
============================================
Files 4082 4081 -1
Lines 58280 58287 +7
Branches 9253 9250 -3
============================================
+ Hits 29039 29081 +42
+ Misses 26684 26653 -31
+ Partials 2557 2553 -4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...saction/xa/XAShardingSphereTransactionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/23352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL3R5cGUveGEvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdHJhbnNhY3Rpb24veGEvWEFTaGFyZGluZ1NwaGVyZVRyYW5zYWN0aW9uTWFuYWdlci5qYXZh) | `67.92% <60.00%> (-0.83%)` | :arrow_down: |
| [...yaml/swapper/YamlAdvisorsConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/23352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9hZHZpc29yL2NvbmZpZy95YW1sL3N3YXBwZXIvWWFtbEFkdmlzb3JzQ29uZmlndXJhdGlvblN3YXBwZXIuamF2YQ==) | `0.00% <0.00%> (-83.34%)` | :arrow_down: |
| [...rnal/asserts/statement/rdl/RDLStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/23352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9pdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3QvaXQvc3FsL3BhcnNlci9pbnRlcm5hbC9hc3NlcnRzL3N0YXRlbWVudC9yZGwvUkRMU3RhdGVtZW50QXNzZXJ0LmphdmE=) | `92.30% <0.00%> (-3.35%)` | :arrow_down: |
| [...uery/binary/execute/MySQLComStmtExecutePacket.java](https://codecov.io/gh/apache/shardingsphere/pull/23352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L2JpbmFyeS9leGVjdXRlL015U1FMQ29tU3RtdEV4ZWN1dGVQYWNrZXQuamF2YQ==) | `90.32% <0.00%> (-2.79%)` | :arrow_down: |
| [...gsphere/agent/plugin/metrics/core/MetricsPool.java](https://codecov.io/gh/apache/shardingsphere/pull/23352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi9tZXRyaWNzL2NvcmUvTWV0cmljc1Bvb2wuamF2YQ==) | `85.71% <0.00%> (-1.79%)` | :arrow_down: |
| [...he/shardingsphere/mode/manager/ContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/23352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvQ29udGV4dE1hbmFnZXIuamF2YQ==) | `54.92% <0.00%> (-1.17%)` | :arrow_down: |
| [.../exception/algorithm/AlgorithmInUsedException.java](https://codecov.io/gh/apache/shardingsphere/pull/23352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL2hhbmRsZXIvZXhjZXB0aW9uL2FsZ29yaXRobS9BbGdvcml0aG1JblVzZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ception/algorithm/DuplicateAlgorithmException.java](https://codecov.io/gh/apache/shardingsphere/pull/23352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL2hhbmRsZXIvZXhjZXB0aW9uL2FsZ29yaXRobS9EdXBsaWNhdGVBbGdvcml0aG1FeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../yaml/swapper/YamlAdvisorConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/23352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9hZHZpc29yL2NvbmZpZy95YW1sL3N3YXBwZXIvWWFtbEFkdmlzb3JDb25maWd1cmF0aW9uU3dhcHBlci5qYXZh) | `100.00% <0.00%> (ø)` | |
| [...n/algorithm/MissingRequiredAlgorithmException.java](https://codecov.io/gh/apache/shardingsphere/pull/23352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL2hhbmRsZXIvZXhjZXB0aW9uL2FsZ29yaXRobS9NaXNzaW5nUmVxdWlyZWRBbGdvcml0aG1FeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/shardingsphere/pull/23352?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org