You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Piyush Hari (JIRA)" <ad...@incubator.apache.org> on 2006/10/10 08:37:19 UTC
[jira] Created: (ADFFACES-228) fic navigationPane on PDAs
fic navigationPane on PDAs
--------------------------
Key: ADFFACES-228
URL: http://issues.apache.org/jira/browse/ADFFACES-228
Project: MyFaces ADF-Faces
Issue Type: Bug
Environment: PDA
Reporter: Piyush Hari
Priority: Minor
The navigationPane component creates a series of navigation items representing one level in a navigation hierarchy. These items may either be added as children or a menu model may be bound to the navigationPane component.
Currently, on a PDA, navigationItem in a "tabs" , "bar" and "button" mode does not display properly. Childern and separators get rendered in a new line and that occupies a lot of real screen estate and at the same time, is confusing to the user.
I plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-228) fix navigationPane on PDAs
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-228?page=all ]
Piyush Hari updated ADFFACES-228:
---------------------------------
Status: Patch Available (was: Open)
> fix navigationPane on PDAs
> --------------------------
>
> Key: ADFFACES-228
> URL: http://issues.apache.org/jira/browse/ADFFACES-228
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct10_01_31AM_navigationPane_pda.patch, patch_oct18_05_23PM_navigationPane_pda.patch
>
>
> The navigationPane component creates a series of navigation items representing one level in a navigation hierarchy. These items may either be added as children or a menu model may be bound to the navigationPane component.
> Currently, on a PDA, navigationItem in a "tabs" , "bar" and "button" mode does not display properly. Childern and separators get rendered in a new line and that occupies a lot of real screen estate and at the same time, is confusing to the user.
> I plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-228) fic navigationPane on PDAs
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-228?page=all ]
Piyush Hari updated ADFFACES-228:
---------------------------------
Status: Patch Available (was: Open)
> fic navigationPane on PDAs
> --------------------------
>
> Key: ADFFACES-228
> URL: http://issues.apache.org/jira/browse/ADFFACES-228
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct10_01_31AM_navigationPane_pda.patch
>
>
> The navigationPane component creates a series of navigation items representing one level in a navigation hierarchy. These items may either be added as children or a menu model may be bound to the navigationPane component.
> Currently, on a PDA, navigationItem in a "tabs" , "bar" and "button" mode does not display properly. Childern and separators get rendered in a new line and that occupies a lot of real screen estate and at the same time, is confusing to the user.
> I plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-228) fix navigationPane on PDAs
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-228?page=comments#action_12443121 ]
Adam Winer commented on ADFFACES-228:
-------------------------------------
Comments on the patch:
- _renderNavigationItem() and _renderNonOverlappingItem() already have RenderingContexts; no need to call getCurrentInstance()
- Some opening braces ('{') are placed on the same line as the code; this is against Trinidad coding standards.
- In general, -1 to adding "isPDA()" checks, especially the way it's done in
_renderNonOverlappingItem(). This would be much better handled
by creating a subclass of NavigationPaneRenderer in the core.pda package that handles
this rendering distinction. It'd be OK to add a couple of protected methods to the
base NavigationPaneRenderer class to enable this.
> fix navigationPane on PDAs
> --------------------------
>
> Key: ADFFACES-228
> URL: http://issues.apache.org/jira/browse/ADFFACES-228
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct10_01_31AM_navigationPane_pda.patch
>
>
> The navigationPane component creates a series of navigation items representing one level in a navigation hierarchy. These items may either be added as children or a menu model may be bound to the navigationPane component.
> Currently, on a PDA, navigationItem in a "tabs" , "bar" and "button" mode does not display properly. Childern and separators get rendered in a new line and that occupies a lot of real screen estate and at the same time, is confusing to the user.
> I plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-228) fix navigationPane on PDAs
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-228?page=all ]
Adam Winer updated ADFFACES-228:
--------------------------------
Status: Open (was: Patch Available)
> fix navigationPane on PDAs
> --------------------------
>
> Key: ADFFACES-228
> URL: http://issues.apache.org/jira/browse/ADFFACES-228
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct10_01_31AM_navigationPane_pda.patch
>
>
> The navigationPane component creates a series of navigation items representing one level in a navigation hierarchy. These items may either be added as children or a menu model may be bound to the navigationPane component.
> Currently, on a PDA, navigationItem in a "tabs" , "bar" and "button" mode does not display properly. Childern and separators get rendered in a new line and that occupies a lot of real screen estate and at the same time, is confusing to the user.
> I plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-228) fix navigationPane on PDAs
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-228?page=all ]
Piyush Hari updated ADFFACES-228:
---------------------------------
Attachment: patch_oct18_05_23PM_navigationPane_pda.patch
I am providing a new patch for this issue as per Adam's suggestion. I have created a renderer subclass inheriting from the existing NavigationPaneRenderer.java and added that as the renderer class for a Navigation pane for PDA in the PDA Render Kit.
> fix navigationPane on PDAs
> --------------------------
>
> Key: ADFFACES-228
> URL: http://issues.apache.org/jira/browse/ADFFACES-228
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct10_01_31AM_navigationPane_pda.patch, patch_oct18_05_23PM_navigationPane_pda.patch
>
>
> The navigationPane component creates a series of navigation items representing one level in a navigation hierarchy. These items may either be added as children or a menu model may be bound to the navigationPane component.
> Currently, on a PDA, navigationItem in a "tabs" , "bar" and "button" mode does not display properly. Childern and separators get rendered in a new line and that occupies a lot of real screen estate and at the same time, is confusing to the user.
> I plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-228) fix navigationPane on PDAs
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-228:
----------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> fix navigationPane on PDAs
> --------------------------
>
> Key: ADFFACES-228
> URL: https://issues.apache.org/jira/browse/ADFFACES-228
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Affects Versions: 1.0.0-incubating-core
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Fix For: 1.0.0-incubating-core
>
> Attachments: patch_oct10_01_31AM_navigationPane_pda.patch, patch_oct20_03_21PM_navigationPane_pda.patch
>
>
> The navigationPane component creates a series of navigation items representing one level in a navigation hierarchy. These items may either be added as children or a menu model may be bound to the navigationPane component.
> Currently, on a PDA, navigationItem in a "tabs" , "bar" and "button" mode does not display properly. Childern and separators get rendered in a new line and that occupies a lot of real screen estate and at the same time, is confusing to the user.
> I plan to fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-228) fix navigationPane on PDAs
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-228?page=all ]
Piyush Hari updated ADFFACES-228:
---------------------------------
Issue Type: Improvement (was: Bug)
> fix navigationPane on PDAs
> --------------------------
>
> Key: ADFFACES-228
> URL: http://issues.apache.org/jira/browse/ADFFACES-228
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct10_01_31AM_navigationPane_pda.patch
>
>
> The navigationPane component creates a series of navigation items representing one level in a navigation hierarchy. These items may either be added as children or a menu model may be bound to the navigationPane component.
> Currently, on a PDA, navigationItem in a "tabs" , "bar" and "button" mode does not display properly. Childern and separators get rendered in a new line and that occupies a lot of real screen estate and at the same time, is confusing to the user.
> I plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-228) fic navigationPane on PDAs
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-228?page=all ]
Piyush Hari updated ADFFACES-228:
---------------------------------
Attachment: patch_oct10_01_31AM_navigationPane_pda.patch
I am providing patch that fixes this issue. (patch_oct10_01_31AM_navigationPane_pda.patch). Pocket PC, IE Mobile and Backberry do not support style="display:inline" attribute of a table and so, I have arranged the children in a span and not a table.
> fic navigationPane on PDAs
> --------------------------
>
> Key: ADFFACES-228
> URL: http://issues.apache.org/jira/browse/ADFFACES-228
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct10_01_31AM_navigationPane_pda.patch
>
>
> The navigationPane component creates a series of navigation items representing one level in a navigation hierarchy. These items may either be added as children or a menu model may be bound to the navigationPane component.
> Currently, on a PDA, navigationItem in a "tabs" , "bar" and "button" mode does not display properly. Childern and separators get rendered in a new line and that occupies a lot of real screen estate and at the same time, is confusing to the user.
> I plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-228) fix navigationPane on PDAs
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-228?page=all ]
Piyush Hari updated ADFFACES-228:
---------------------------------
Summary: fix navigationPane on PDAs (was: fic navigationPane on PDAs)
just a typo...
> fix navigationPane on PDAs
> --------------------------
>
> Key: ADFFACES-228
> URL: http://issues.apache.org/jira/browse/ADFFACES-228
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct10_01_31AM_navigationPane_pda.patch
>
>
> The navigationPane component creates a series of navigation items representing one level in a navigation hierarchy. These items may either be added as children or a menu model may be bound to the navigationPane component.
> Currently, on a PDA, navigationItem in a "tabs" , "bar" and "button" mode does not display properly. Childern and separators get rendered in a new line and that occupies a lot of real screen estate and at the same time, is confusing to the user.
> I plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira