You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ShivsundarR (via GitHub)" <gi...@apache.org> on 2024/11/04 14:16:48 UTC
[PR] KAFKA-17938: Removed Set.of usage in ReplicationControlManagerTest [kafka]
ShivsundarR opened a new pull request, #17683:
URL: https://github.com/apache/kafka/pull/17683
*What*
Removed Set.of usage in ReplicationControlManagerTest as it is not compatible with java 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17938: Removed Set.of usage in ReplicationControlManagerTest [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on PR #17683:
URL: https://github.com/apache/kafka/pull/17683#issuecomment-2459788469
@lianetm @ShivsundarR we need this on 3.8 as well, I think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17938: Removed Set.of usage in ReplicationControlManagerTest [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on PR #17683:
URL: https://github.com/apache/kafka/pull/17683#issuecomment-2459900868
Makes sense, thanks @lucasbru!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17938: Removed Set.of usage in ReplicationControlManagerTest [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on PR #17683:
URL: https://github.com/apache/kafka/pull/17683#issuecomment-2455486445
Updated test passed (other unrelated test failures)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17938: Removed Set.of usage in ReplicationControlManagerTest [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm merged PR #17683:
URL: https://github.com/apache/kafka/pull/17683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17938: Removed Set.of usage in ReplicationControlManagerTest [kafka]
Posted by "ShivsundarR (via GitHub)" <gi...@apache.org>.
ShivsundarR commented on PR #17683:
URL: https://github.com/apache/kafka/pull/17683#issuecomment-2459847519
Thanks @lucasbru, yes just saw we do need this change on 3.8 as well. I have raised a PR for the same - https://github.com/apache/kafka/pull/17703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org