You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/10 10:11:08 UTC
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4693:
Refactor MySQL generic and auth protocol packets.
codecov-io commented on issue #4693: Refactor MySQL generic and auth protocol packets.
URL: https://github.com/apache/incubator-shardingsphere/pull/4693#issuecomment-597005560
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693?src=pr&el=h1) Report
> Merging [#4693](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6fcd9b4bc8d4747d85d28bb948c0d5fc0cec8ce0?src=pr&el=desc) will **increase** coverage by `0.1%`.
> The diff coverage is `91.35%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4693 +/- ##
===========================================
+ Coverage 55.48% 55.58% +0.1%
Complexity 426 426
===========================================
Files 1134 1135 +1
Lines 20492 20553 +61
Branches 3799 3812 +13
===========================================
+ Hits 11369 11425 +56
Misses 8409 8409
- Partials 714 719 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...abase/protocol/mysql/constant/MySQLStatusFlag.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMU3RhdHVzRmxhZy5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ocol/mysql/constant/MySQLAuthenticationMethod.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMQXV0aGVudGljYXRpb25NZXRob2QuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...cket/handshake/MySQLHandshakeResponse41Packet.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxIYW5kc2hha2VSZXNwb25zZTQxUGFja2V0LmphdmE=) | `97.91% <100%> (+0.69%)` | `0 <0> (ø)` | :arrow_down: |
| [.../protocol/mysql/packet/generic/MySQLEofPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9nZW5lcmljL015U1FMRW9mUGFja2V0LmphdmE=) | `84.61% <83.33%> (-1.1%)` | `0 <0> (ø)` | |
| [...l/mysql/packet/handshake/MySQLHandshakePacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxIYW5kc2hha2VQYWNrZXQuamF2YQ==) | `88.88% <87.5%> (-0.59%)` | `1 <0> (ø)` | |
| [.../protocol/mysql/packet/generic/MySQLErrPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9nZW5lcmljL015U1FMRXJyUGFja2V0LmphdmE=) | `88.23% <87.5%> (-0.66%)` | `0 <0> (ø)` | |
| [...e/protocol/mysql/packet/generic/MySQLOKPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9nZW5lcmljL015U1FMT0tQYWNrZXQuamF2YQ==) | `90.9% <92.3%> (-1.4%)` | `0 <0> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693?src=pr&el=footer). Last update [6fcd9b4...06c46a1](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services