You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/07/07 09:36:04 UTC

[jira] [Commented] (CB-8222) play media in background thread

    [ https://issues.apache.org/jira/browse/CB-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616320#comment-14616320 ] 

ASF GitHub Bot commented on CB-8222:
------------------------------------

GitHub user ghenry22 opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/60

    CB-8222 Background threading for Audio Plugin

    Start playback with background thread so that UI is not blocked when playing sounds with the media plugin.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ghenry22/cordova-plugin-media CB-8222-background-threads-for-media-plugin

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #60
    
----
commit afb82b4bb841258408242409adcfe77557888459
Author: ghenry22 <gh...@gmail.com>
Date:   2015-07-07T07:27:35Z

    Add background threading to play command

----


> play media in background thread
> -------------------------------
>
>                 Key: CB-8222
>                 URL: https://issues.apache.org/jira/browse/CB-8222
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Media
>    Affects Versions: 3.5.0
>         Environment: Xcode
> iOS
>            Reporter: Ralf Koch
>              Labels: performance
>
> Xcode gives a warning with in example the Media plugin playing a tiny mp3 file for taking too long, even though it is about 50ms and recommends background thread which is actually easy to implement.
> Could you guys do this or is there a reason not to?
> I would think it should be in the "CDVSound.m" --> "- (void)startPlayingAudio:(CDVInvokedUrlCommand*)command" command, is this correct?
> Best regards
> Ralf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org