You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "jayeshchoudhary (via GitHub)" <gi...@apache.org> on 2023/05/16 10:03:08 UTC
[GitHub] [pinot] jayeshchoudhary opened a new pull request, #10770: UI: fix sql query options seperator
jayeshchoudhary opened a new pull request, #10770:
URL: https://github.com/apache/pinot/pull/10770
This PR is `ui` `bugfix`
### Issue
- In the SQL editor If there were multiple query options, then queryOptions passed to payload were incorrect.
- Backend expects `;` as a separator between multiple queryOptions
### Fix
- Separate query options by `;`
<hr>
Payload before
```json
{
"sql": "select * from baseballStats limit 10",
"trace": true,
"queryOptions": "timeoutMs=1000useMultistageEngine=true"
}
```
Payload After
```json
{
"sql": "select * from baseballStats limit 10",
"trace": true,
"queryOptions": "timeoutMs=1000;useMultistageEngine=true"
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10770: UI: fix sql query options seperator
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10770:
URL: https://github.com/apache/pinot/pull/10770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jayeshchoudhary commented on pull request #10770: UI: fix sql query options seperator
Posted by "jayeshchoudhary (via GitHub)" <gi...@apache.org>.
jayeshchoudhary commented on PR #10770:
URL: https://github.com/apache/pinot/pull/10770#issuecomment-1668309668
@Jackie-Jiang @saurabhd336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10770: UI: fix sql query options seperator
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10770:
URL: https://github.com/apache/pinot/pull/10770#issuecomment-1549424374
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10770?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10770](https://app.codecov.io/gh/apache/pinot/pull/10770?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (215d5ab) into [master](https://app.codecov.io/gh/apache/pinot/commit/579082c8030d9c1d9f61cd078229fca96f4d35ee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (579082c) will **decrease** coverage by `50.72%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #10770 +/- ##
=============================================
- Coverage 64.40% 13.69% -50.72%
+ Complexity 6446 439 -6007
=============================================
Files 2098 2098
Lines 113315 113315
Branches 17204 17204
=============================================
- Hits 72984 15518 -57466
- Misses 35082 96523 +61441
+ Partials 5249 1274 -3975
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests1 | `?` | |
| unittests2 | `13.69% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1448 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10770/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org