You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Bruno Peeters (JIRA)" <ji...@apache.org> on 2009/02/16 13:51:01 UTC
[jira] Created: (JSPWIKI-505) No more
separators in wiki
system variables
No more <br /> separators in wiki system variables
--------------------------------------------------
Key: JSPWIKI-505
URL: https://issues.apache.org/jira/browse/JSPWIKI-505
Project: JSPWiki
Issue Type: Bug
Affects Versions: 2.8.1
Reporter: Bruno Peeters
Priority: Minor
We have noticed that information on the Systeminfo page (http://www.jspwiki.org/wiki/SystemInfo) is less userfriendly presented compared to the previous version of jspwiki we are using (2.2.33). All information items are put on one single line, which makes it harder to get a clear view on the information presented, eg the available interwiki links.
Why were the <br /> separators removed from the variables ?
Would it be possible to add an option to indicate whether the information would be presented with or without breaks ?
Concerned wiki variables
Current Page Provider {$pageproviderdescription}
Current Attachment Provider {$attachmentProviderDescription}
Available InterWiki links {$interwikilinks}
Inlined images are {$inlinedimages}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (JSPWIKI-505) No more
separators in wiki
system variables
Posted by Harry Metske <ha...@gmail.com>.
Well, I noticed that, and was too lazy :-)
Also, a couple of other plugins have the same issue, I'll patch them all in
one go, the next few days.
Harry
2009/2/25 Janne Jalkanen (JIRA) <ji...@apache.org>
>
> [
> https://issues.apache.org/jira/browse/JSPWIKI-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676784#action_12676784]
>
> Janne Jalkanen commented on JSPWIKI-505:
> ----------------------------------------
>
> Patch looks good with a minor nitpick: the error should be localized :-)
>
> > No more <br /> separators in wiki system variables
> > --------------------------------------------------
> >
> > Key: JSPWIKI-505
> > URL: https://issues.apache.org/jira/browse/JSPWIKI-505
> > Project: JSPWiki
> > Issue Type: Bug
> > Affects Versions: 2.8.1
> > Reporter: Bruno Peeters
> > Assignee: Harry Metske
> > Priority: Minor
> > Fix For: 3.0
> >
> > Attachments: patch-interwikilinks.txt
> >
> >
> > We have noticed that information on the Systeminfo page (
> http://www.jspwiki.org/wiki/SystemInfo) is less userfriendly presented
> compared to the previous version of jspwiki we are using (2.2.33). All
> information items are put on one single line, which makes it harder to get a
> clear view on the information presented, eg the available interwiki links.
> > Why were the <br /> separators removed from the variables ?
> > Would it be possible to add an option to indicate whether the information
> would be presented with or without breaks ?
> > Concerned wiki variables
> > Current Page Provider {$pageproviderdescription}
> > Current Attachment Provider {$attachmentProviderDescription}
> > Available InterWiki links {$interwikilinks}
> > Inlined images are {$inlinedimages}
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (JSPWIKI-505) No more
separators in wiki
system variables
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676784#action_12676784 ]
Janne Jalkanen commented on JSPWIKI-505:
----------------------------------------
Patch looks good with a minor nitpick: the error should be localized :-)
> No more <br /> separators in wiki system variables
> --------------------------------------------------
>
> Key: JSPWIKI-505
> URL: https://issues.apache.org/jira/browse/JSPWIKI-505
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 3.0
>
> Attachments: patch-interwikilinks.txt
>
>
> We have noticed that information on the Systeminfo page (http://www.jspwiki.org/wiki/SystemInfo) is less userfriendly presented compared to the previous version of jspwiki we are using (2.2.33). All information items are put on one single line, which makes it harder to get a clear view on the information presented, eg the available interwiki links.
> Why were the <br /> separators removed from the variables ?
> Would it be possible to add an option to indicate whether the information would be presented with or without breaks ?
> Concerned wiki variables
> Current Page Provider {$pageproviderdescription}
> Current Attachment Provider {$attachmentProviderDescription}
> Available InterWiki links {$interwikilinks}
> Inlined images are {$inlinedimages}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-505) No more
separators in wiki
system variables
Posted by "Wouter Van daele (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675701#action_12675701 ]
Wouter Van daele commented on JSPWIKI-505:
------------------------------------------
I've made a plugin called 'InterwikiLinks'; you can find source code and a compiled version on my blog at << http://nukleos.editthispage.com/2009/02/22 >>. Currently created in the package 'com.nukleos.jspwiki.plugin', you're free to copy and adapt the code for JSPWiki 2.8 and up. I'll add a formal description of its usage ASAP.
> No more <br /> separators in wiki system variables
> --------------------------------------------------
>
> Key: JSPWIKI-505
> URL: https://issues.apache.org/jira/browse/JSPWIKI-505
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
>
> We have noticed that information on the Systeminfo page (http://www.jspwiki.org/wiki/SystemInfo) is less userfriendly presented compared to the previous version of jspwiki we are using (2.2.33). All information items are put on one single line, which makes it harder to get a clear view on the information presented, eg the available interwiki links.
> Why were the <br /> separators removed from the variables ?
> Would it be possible to add an option to indicate whether the information would be presented with or without breaks ?
> Concerned wiki variables
> Current Page Provider {$pageproviderdescription}
> Current Attachment Provider {$attachmentProviderDescription}
> Available InterWiki links {$interwikilinks}
> Inlined images are {$inlinedimages}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-505) No more
separators in wiki
system variables
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675705#action_12675705 ]
Janne Jalkanen commented on JSPWIKI-505:
----------------------------------------
For legal reasons I think it needs to be added as a patch here or contributed with a SGA.
> No more <br /> separators in wiki system variables
> --------------------------------------------------
>
> Key: JSPWIKI-505
> URL: https://issues.apache.org/jira/browse/JSPWIKI-505
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
>
> We have noticed that information on the Systeminfo page (http://www.jspwiki.org/wiki/SystemInfo) is less userfriendly presented compared to the previous version of jspwiki we are using (2.2.33). All information items are put on one single line, which makes it harder to get a clear view on the information presented, eg the available interwiki links.
> Why were the <br /> separators removed from the variables ?
> Would it be possible to add an option to indicate whether the information would be presented with or without breaks ?
> Concerned wiki variables
> Current Page Provider {$pageproviderdescription}
> Current Attachment Provider {$attachmentProviderDescription}
> Available InterWiki links {$interwikilinks}
> Inlined images are {$inlinedimages}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-505) No more
separators in wiki
system variables
Posted by "Wouter Van daele (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674682#action_12674682 ]
Wouter Van daele commented on JSPWIKI-505:
------------------------------------------
Janne, I can understand your reluctance to offer information about the configuration of the system when it concerns the general principle.
However, the Interwiki links are a special case. If we can't show them to the editors of our pages, noone is going to use them. So it would be nice to be able to display them in a more readable format than just running text.
As an alternative to the current variable output I'm whipping together a plugin to display the Interwiki links in several formats; responsability for the possible security hole then lies with the admin who installs the plugin... ;-)
PS. Disclaimers: Bruno Peeters is a collegue of mine. Our JSPWiki instance is strictly limited to the company intranet, so security is less of an issue.
> No more <br /> separators in wiki system variables
> --------------------------------------------------
>
> Key: JSPWIKI-505
> URL: https://issues.apache.org/jira/browse/JSPWIKI-505
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
>
> We have noticed that information on the Systeminfo page (http://www.jspwiki.org/wiki/SystemInfo) is less userfriendly presented compared to the previous version of jspwiki we are using (2.2.33). All information items are put on one single line, which makes it harder to get a clear view on the information presented, eg the available interwiki links.
> Why were the <br /> separators removed from the variables ?
> Would it be possible to add an option to indicate whether the information would be presented with or without breaks ?
> Concerned wiki variables
> Current Page Provider {$pageproviderdescription}
> Current Attachment Provider {$attachmentProviderDescription}
> Available InterWiki links {$interwikilinks}
> Inlined images are {$inlinedimages}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-505) No more
separators in wiki
system variables
Posted by "Wouter Van daele (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677041#action_12677041 ]
Wouter Van daele commented on JSPWIKI-505:
------------------------------------------
Of course, I should have thought about that! Glad you caught that.
> No more <br /> separators in wiki system variables
> --------------------------------------------------
>
> Key: JSPWIKI-505
> URL: https://issues.apache.org/jira/browse/JSPWIKI-505
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 3.0
>
> Attachments: patch-interwikilinks.txt
>
>
> We have noticed that information on the Systeminfo page (http://www.jspwiki.org/wiki/SystemInfo) is less userfriendly presented compared to the previous version of jspwiki we are using (2.2.33). All information items are put on one single line, which makes it harder to get a clear view on the information presented, eg the available interwiki links.
> Why were the <br /> separators removed from the variables ?
> Would it be possible to add an option to indicate whether the information would be presented with or without breaks ?
> Concerned wiki variables
> Current Page Provider {$pageproviderdescription}
> Current Attachment Provider {$attachmentProviderDescription}
> Available InterWiki links {$interwikilinks}
> Inlined images are {$inlinedimages}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-505) No more
separators in wiki
system variables
Posted by "Wouter Van daele (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wouter Van daele updated JSPWIKI-505:
-------------------------------------
Attachment: patch-interwikilinks.txt
Patch with complete source code is attached to this ticket. Enjoy!
> No more <br /> separators in wiki system variables
> --------------------------------------------------
>
> Key: JSPWIKI-505
> URL: https://issues.apache.org/jira/browse/JSPWIKI-505
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Attachments: patch-interwikilinks.txt
>
>
> We have noticed that information on the Systeminfo page (http://www.jspwiki.org/wiki/SystemInfo) is less userfriendly presented compared to the previous version of jspwiki we are using (2.2.33). All information items are put on one single line, which makes it harder to get a clear view on the information presented, eg the available interwiki links.
> Why were the <br /> separators removed from the variables ?
> Would it be possible to add an option to indicate whether the information would be presented with or without breaks ?
> Concerned wiki variables
> Current Page Provider {$pageproviderdescription}
> Current Attachment Provider {$attachmentProviderDescription}
> Available InterWiki links {$interwikilinks}
> Inlined images are {$inlinedimages}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-505) No more
separators in wiki
system variables
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674690#action_12674690 ]
Janne Jalkanen commented on JSPWIKI-505:
----------------------------------------
I agree, interwiki links are a special case. A separate plugin is probably a better idea, since the idea of a variable outputting HTML makes me feel kinda iffy these days.
If you can contribute the plugin, we'd love to take it for 3.0!
> No more <br /> separators in wiki system variables
> --------------------------------------------------
>
> Key: JSPWIKI-505
> URL: https://issues.apache.org/jira/browse/JSPWIKI-505
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
>
> We have noticed that information on the Systeminfo page (http://www.jspwiki.org/wiki/SystemInfo) is less userfriendly presented compared to the previous version of jspwiki we are using (2.2.33). All information items are put on one single line, which makes it harder to get a clear view on the information presented, eg the available interwiki links.
> Why were the <br /> separators removed from the variables ?
> Would it be possible to add an option to indicate whether the information would be presented with or without breaks ?
> Concerned wiki variables
> Current Page Provider {$pageproviderdescription}
> Current Attachment Provider {$attachmentProviderDescription}
> Available InterWiki links {$interwikilinks}
> Inlined images are {$inlinedimages}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-505) No more
separators in wiki
system variables
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677156#action_12677156 ]
Harry Metske commented on JSPWIKI-505:
--------------------------------------
message now localized
> No more <br /> separators in wiki system variables
> --------------------------------------------------
>
> Key: JSPWIKI-505
> URL: https://issues.apache.org/jira/browse/JSPWIKI-505
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 3.0
>
> Attachments: patch-interwikilinks.txt
>
>
> We have noticed that information on the Systeminfo page (http://www.jspwiki.org/wiki/SystemInfo) is less userfriendly presented compared to the previous version of jspwiki we are using (2.2.33). All information items are put on one single line, which makes it harder to get a clear view on the information presented, eg the available interwiki links.
> Why were the <br /> separators removed from the variables ?
> Would it be possible to add an option to indicate whether the information would be presented with or without breaks ?
> Concerned wiki variables
> Current Page Provider {$pageproviderdescription}
> Current Attachment Provider {$attachmentProviderDescription}
> Available InterWiki links {$interwikilinks}
> Inlined images are {$inlinedimages}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-505) No more
separators in wiki
system variables
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673876#action_12673876 ]
Janne Jalkanen commented on JSPWIKI-505:
----------------------------------------
Variable output is escaped because of security concerns. It is less userfriendly, yes, but unfortunately security often is.
In fact, I think that most of the variables are also a security risk (they give information to the attacker), so we should remove variables like $pageproviderdescription and so on.
No plans to change this behaviour - not escaping the line breaks would result in a fairly massive security hole just to make another security hole look nicer. Not a good tradeoff, methinks.
> No more <br /> separators in wiki system variables
> --------------------------------------------------
>
> Key: JSPWIKI-505
> URL: https://issues.apache.org/jira/browse/JSPWIKI-505
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
>
> We have noticed that information on the Systeminfo page (http://www.jspwiki.org/wiki/SystemInfo) is less userfriendly presented compared to the previous version of jspwiki we are using (2.2.33). All information items are put on one single line, which makes it harder to get a clear view on the information presented, eg the available interwiki links.
> Why were the <br /> separators removed from the variables ?
> Would it be possible to add an option to indicate whether the information would be presented with or without breaks ?
> Concerned wiki variables
> Current Page Provider {$pageproviderdescription}
> Current Attachment Provider {$attachmentProviderDescription}
> Available InterWiki links {$interwikilinks}
> Inlined images are {$inlinedimages}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (JSPWIKI-505) No more
separators in wiki
system variables
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harry Metske closed JSPWIKI-505.
--------------------------------
Resolution: Fixed
Fix Version/s: 3.0
fixed in 3.0.0-svn-73
> No more <br /> separators in wiki system variables
> --------------------------------------------------
>
> Key: JSPWIKI-505
> URL: https://issues.apache.org/jira/browse/JSPWIKI-505
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 3.0
>
> Attachments: patch-interwikilinks.txt
>
>
> We have noticed that information on the Systeminfo page (http://www.jspwiki.org/wiki/SystemInfo) is less userfriendly presented compared to the previous version of jspwiki we are using (2.2.33). All information items are put on one single line, which makes it harder to get a clear view on the information presented, eg the available interwiki links.
> Why were the <br /> separators removed from the variables ?
> Would it be possible to add an option to indicate whether the information would be presented with or without breaks ?
> Concerned wiki variables
> Current Page Provider {$pageproviderdescription}
> Current Attachment Provider {$attachmentProviderDescription}
> Available InterWiki links {$interwikilinks}
> Inlined images are {$inlinedimages}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.