You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/07/19 20:34:08 UTC
[GitHub] [trafficserver] serrislew opened a new pull request #8085: Add cache condition in header_rewrite plugin for lookup results
serrislew opened a new pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-885274128
Could this new condition be tested in an Au test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on a change in pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#discussion_r672690848
##########
File path: plugins/header_rewrite/conditions.h
##########
@@ -583,3 +583,22 @@ class ConditionTcpInfo : public Condition
bool eval(const Resources &res) override;
void initialize_hooks() override; // Return status only valid in certain hooks
};
+
+// Cache Lookup Results
+class ConditionCache : public Condition
+{
+ typedef Matchers<std::string> MatcherType;
Review comment:
`using MatcherType = Matchers<std::string>;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-882844088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-882960093
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-882844088
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-886897723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-882919749
Needs documentation and a better description for the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-887094822
@SolidWallOfCode is going to look at this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-882919749
Needs documentation and a better description for the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-887772173
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-882919749
Needs documentation and a better description for the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-883435489
@serrislew you need to run "make clang-format" on the branch to get the clang-format step happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-886897723
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich removed a comment on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
shinrich removed a comment on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-882960093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-887675108
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on a change in pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#discussion_r672690848
##########
File path: plugins/header_rewrite/conditions.h
##########
@@ -583,3 +583,22 @@ class ConditionTcpInfo : public Condition
bool eval(const Resources &res) override;
void initialize_hooks() override; // Return status only valid in certain hooks
};
+
+// Cache Lookup Results
+class ConditionCache : public Condition
+{
+ typedef Matchers<std::string> MatcherType;
Review comment:
`using MatcherType = Matchers<std::string>;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-887772173
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-887094251
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on a change in pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#discussion_r672690848
##########
File path: plugins/header_rewrite/conditions.h
##########
@@ -583,3 +583,22 @@ class ConditionTcpInfo : public Condition
bool eval(const Resources &res) override;
void initialize_hooks() override; // Return status only valid in certain hooks
};
+
+// Cache Lookup Results
+class ConditionCache : public Condition
+{
+ typedef Matchers<std::string> MatcherType;
Review comment:
`using MatcherType = Matchers<std::string>;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew edited a comment on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
serrislew edited a comment on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-887120296
@SolidWallOfCode before you review, I would like to add an example use case of this cache condition in the docs
Update: Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-883533812
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-882844088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-920373270
This is a new feature, and I don't think we should merge this into a 9.1.x patch release. Rather, lets defer this for 9.2.x, which we will branch soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
serrislew commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-887120296
@SolidWallOfCode before you review, I would like to add an example use case of this cache condition in the docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall merged pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
randall merged pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-887675108
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew edited a comment on pull request #8085: Add cache condition in header_rewrite plugin for lookup results
Posted by GitBox <gi...@apache.org>.
serrislew edited a comment on pull request #8085:
URL: https://github.com/apache/trafficserver/pull/8085#issuecomment-887120296
@SolidWallOfCode before you review, I would like to add an example use case of this cache condition in the docs
Update: Added examples to doc. Available to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org