You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Lieven Govaerts <sv...@mobsol.be> on 2008/09/29 01:42:24 UTC
Re: svn commit: r33335 - in trunk: . build build/generator build/generator/swig
build/win32
arfrever@tigris.org wrote:
> Author: arfrever
> Date: Sun Sep 28 08:06:24 2008
> New Revision: 33335
>
> Log:
> Python 3 compatibility:
> Update calls to print() in 'build' directory, 'gen-make.py' and 'win-tests.py'.
>
> * build/generator/extractor.py:
> * build/generator/gen_win.py:
> * build/generator/swig/checkout_swig_header.py:
> * build/generator/swig/external_runtime.py:
> * build/generator/swig/header_wrappers.py:
> * build/get-py-info.py:
> * build/getversion.py:
> * build/run_tests.py:
> * build/strip-po-charset.py:
> * build/win32/make_dist.py:
> * gen-make.py:
> * win-tests.py: Call print() or <file>.write().
This change breaks the swig build on the Mac buildslave, which uses
Python 2.3.5. I see that in some cases "()" characters are printed in
the output.
Example 1: Note the '()' around the gcc part.
/bin/sh: -c: line 1: `/bin/sh
/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/libtool --tag=CC
--silent --mode=compile ('gcc', '-fno-strict-aliasing -Wno-long-double
-no-cpp-precomp -mno-fused-madd -fno-common -dynamic -DNDEBUG -g -O3
-Wall -Wstrict-prototypes', '') -DDARWIN
..
/bin/sh: -c: line 1: syntax error near unexpected token `('
Example 2: 'print()' puts '()' on screen.
lgomac:~/slavedir/osx10.4-gcc4.0.1-ia32/build lgo$ ./gen-make.py --help
USAGE: gen-make.py [options...] [conf-file]
-s skip dependency generation
..
vcproj VC.Net project files
()
The default generator type is 'make'
()
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r33335 - in trunk: . build build/generator build/generator/swig build/win32
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-09-30 18:43:38 Blair Zajac napisał(a):
> I'm not saying that for cross-platform work you need to find a Windows box.
>
> But if you're on Linux or Mac OS X and build Python 3.0 rcX from source which
> hasn't seen an official release yet, then presumably there's a Python 2.x on the
> system that you can test changes with.
I was testing the changes with Python 2.* before committing, but there wasn't
any traceback and I didn't try to build SWIG Python bindings, so I didn't notice
this problem.
(I have dev-lang/python-2.5.2-r7, dev-lang/python-2.6_rc2 and dev-lang/python-3.0_rc1.
They all were installed using Portage, Gentoo official package manager.)
> Greg Stein wrote:
> > Nope. That's never been the policy. Most of us don't have Windows
> > systems, so we have never been obligated to verify that our changes
> > remain compatible there.
> >
> > On Tue, Sep 30, 2008 at 9:33 AM, Blair Zajac <bl...@orcaware.com> wrote:
> >> The advice I have is if one is making changes for a newer version of a
> >> dependency is to find a system or do a build that has the old version of the
> >> dependency and apply the diff to the old system to ensure it works. One
> >> ideally shouldn't have to rely upon other developers to catch these issues,
> >> the committer should take care to see that their changes are compatible with
> >> both systems.
> >>
> >> Blair
> >>
> >> Greg Stein wrote:
> >>> I see no reason to not make changes for additional compatibility. I did
> >>> examine one his constructs to ensure it remained compatible with 2.2.
> >>>
> >>>
> >>> On Sep 30, 2008, at 8:33, Eric Gillespie <ep...@pretzelnet.org> wrote:
> >>>
> >>>> Greg Stein <gs...@gmail.com> writes:
> >>>>
> >>>>>>> Author: arfrever
> >>>>>>> Date: Sun Sep 28 08:06:24 2008
> >>>>>>> New Revision: 33335
> >>>>>>>
> >>>>>>> Log:
> >>>>>>> Python 3 compatibility:
> >>>> This "must support latest version" dance is really getting out of
> >>>> hand now.
--
Arfrever Frehtes Taifersar Arahesis
Re: svn commit: r33335 - in trunk: . build build/generator build/generator/swig
build/win32
Posted by Blair Zajac <bl...@orcaware.com>.
I'm not saying that for cross-platform work you need to find a Windows box.
But if you're on Linux or Mac OS X and build Python 3.0 rcX from source which
hasn't seen an official release yet, then presumably there's a Python 2.x on the
system that you can test changes with.
Blair
Greg Stein wrote:
> Nope. That's never been the policy. Most of us don't have Windows
> systems, so we have never been obligated to verify that our changes
> remain compatible there.
>
> On Tue, Sep 30, 2008 at 9:33 AM, Blair Zajac <bl...@orcaware.com> wrote:
>> The advice I have is if one is making changes for a newer version of a
>> dependency is to find a system or do a build that has the old version of the
>> dependency and apply the diff to the old system to ensure it works. One
>> ideally shouldn't have to rely upon other developers to catch these issues,
>> the committer should take care to see that their changes are compatible with
>> both systems.
>>
>> Blair
>>
>> Greg Stein wrote:
>>> I see no reason to not make changes for additional compatibility. I did
>>> examine one his constructs to ensure it remained compatible with 2.2.
>>>
>>>
>>> On Sep 30, 2008, at 8:33, Eric Gillespie <ep...@pretzelnet.org> wrote:
>>>
>>>> Greg Stein <gs...@gmail.com> writes:
>>>>
>>>>>>> Author: arfrever
>>>>>>> Date: Sun Sep 28 08:06:24 2008
>>>>>>> New Revision: 33335
>>>>>>>
>>>>>>> Log:
>>>>>>> Python 3 compatibility:
>>>> This "must support latest version" dance is really getting out of
>>>> hand now.
>>>>
>>>> --Eric Gillespie <*> epg@pretzelnet.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
--
Blair Zajac, Ph.D.
CTO, OrcaWare Technologies
<bl...@orcaware.com>
Subversion training, consulting and support
http://www.orcaware.com/svn/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r33335 - in trunk: . build build/generator build/generator/swig build/win32
Posted by Greg Stein <gs...@gmail.com>.
Nope. That's never been the policy. Most of us don't have Windows
systems, so we have never been obligated to verify that our changes
remain compatible there.
On Tue, Sep 30, 2008 at 9:33 AM, Blair Zajac <bl...@orcaware.com> wrote:
> The advice I have is if one is making changes for a newer version of a
> dependency is to find a system or do a build that has the old version of the
> dependency and apply the diff to the old system to ensure it works. One
> ideally shouldn't have to rely upon other developers to catch these issues,
> the committer should take care to see that their changes are compatible with
> both systems.
>
> Blair
>
> Greg Stein wrote:
>>
>> I see no reason to not make changes for additional compatibility. I did
>> examine one his constructs to ensure it remained compatible with 2.2.
>>
>>
>> On Sep 30, 2008, at 8:33, Eric Gillespie <ep...@pretzelnet.org> wrote:
>>
>>> Greg Stein <gs...@gmail.com> writes:
>>>
>>>>>> Author: arfrever
>>>>>> Date: Sun Sep 28 08:06:24 2008
>>>>>> New Revision: 33335
>>>>>>
>>>>>> Log:
>>>>>> Python 3 compatibility:
>>>
>>> This "must support latest version" dance is really getting out of
>>> hand now.
>>>
>>> --Eric Gillespie <*> epg@pretzelnet.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r33335 - in trunk: . build build/generator build/generator/swig
build/win32
Posted by Blair Zajac <bl...@orcaware.com>.
The advice I have is if one is making changes for a newer version of a
dependency is to find a system or do a build that has the old version of the
dependency and apply the diff to the old system to ensure it works. One ideally
shouldn't have to rely upon other developers to catch these issues, the
committer should take care to see that their changes are compatible with both
systems.
Blair
Greg Stein wrote:
> I see no reason to not make changes for additional compatibility. I did
> examine one his constructs to ensure it remained compatible with 2.2.
>
>
> On Sep 30, 2008, at 8:33, Eric Gillespie <ep...@pretzelnet.org> wrote:
>
>> Greg Stein <gs...@gmail.com> writes:
>>
>>>>> Author: arfrever
>>>>> Date: Sun Sep 28 08:06:24 2008
>>>>> New Revision: 33335
>>>>>
>>>>> Log:
>>>>> Python 3 compatibility:
>>
>> This "must support latest version" dance is really getting out of
>> hand now.
>>
>> --Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r33335 - in trunk: . build build/generator build/generator/swig build/win32
Posted by Greg Stein <gs...@gmail.com>.
I see no reason to not make changes for additional compatibility. I
did examine one his constructs to ensure it remained compatible with
2.2.
On Sep 30, 2008, at 8:33, Eric Gillespie <ep...@pretzelnet.org> wrote:
> Greg Stein <gs...@gmail.com> writes:
>
>>>> Author: arfrever
>>>> Date: Sun Sep 28 08:06:24 2008
>>>> New Revision: 33335
>>>>
>>>> Log:
>>>> Python 3 compatibility:
>
> This "must support latest version" dance is really getting out of
> hand now.
>
> --
> Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r33335 - in trunk: . build build/generator build/generator/swig build/win32
Posted by Eric Gillespie <ep...@pretzelnet.org>.
Greg Stein <gs...@gmail.com> writes:
> >> Author: arfrever
> >> Date: Sun Sep 28 08:06:24 2008
> >> New Revision: 33335
> >>
> >> Log:
> >> Python 3 compatibility:
This "must support latest version" dance is really getting out of
hand now.
--
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r33335 - in trunk: . build build/generator build/generator/swig build/win32
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-09-29 03:50:19 Greg Stein napisał(a):
> Oop. Yeah!
>
> Arfrever: the cause is from lines like:
>
> print a, b
> became:
> print(a,b)
>
> in Python < 3.0, that is printing out a tuple. The correct conversion is:
>
> print("%s %s" % (a, b))
>
> in many cases, A is a string, so a typical conversion might be:
>
> print "Path:", foo
> to:
> print("Path: %s" % foo)
Fixed in r33349.
> On Sun, Sep 28, 2008 at 6:42 PM, Lieven Govaerts <sv...@mobsol.be> wrote:
> > arfrever@tigris.org wrote:
> >> Author: arfrever
> >> Date: Sun Sep 28 08:06:24 2008
> >> New Revision: 33335
> >>
> >> Log:
> >> Python 3 compatibility:
> >> Update calls to print() in 'build' directory, 'gen-make.py' and 'win-tests.py'.
> >>
> >> * build/generator/extractor.py:
> >> * build/generator/gen_win.py:
> >> * build/generator/swig/checkout_swig_header.py:
> >> * build/generator/swig/external_runtime.py:
> >> * build/generator/swig/header_wrappers.py:
> >> * build/get-py-info.py:
> >> * build/getversion.py:
> >> * build/run_tests.py:
> >> * build/strip-po-charset.py:
> >> * build/win32/make_dist.py:
> >> * gen-make.py:
> >> * win-tests.py: Call print() or <file>.write().
> >
> > This change breaks the swig build on the Mac buildslave, which uses
> > Python 2.3.5. I see that in some cases "()" characters are printed in
> > the output.
> >
> > Example 1: Note the '()' around the gcc part.
> > /bin/sh: -c: line 1: `/bin/sh
> > /Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/libtool --tag=CC
> > --silent --mode=compile ('gcc', '-fno-strict-aliasing -Wno-long-double
> > -no-cpp-precomp -mno-fused-madd -fno-common -dynamic -DNDEBUG -g -O3
> > -Wall -Wstrict-prototypes', '') -DDARWIN
> > ..
> > /bin/sh: -c: line 1: syntax error near unexpected token `('
> >
> > Example 2: 'print()' puts '()' on screen.
> > lgomac:~/slavedir/osx10.4-gcc4.0.1-ia32/build lgo$ ./gen-make.py --help
> > USAGE: gen-make.py [options...] [conf-file]
> > -s skip dependency generation
> > ..
> > vcproj VC.Net project files
> > ()
> > The default generator type is 'make'
> > ()
> >
--
Arfrever Frehtes Taifersar Arahesis
Re: svn commit: r33335 - in trunk: . build build/generator build/generator/swig build/win32
Posted by Greg Stein <gs...@gmail.com>.
Oop. Yeah!
Arfrever: the cause is from lines like:
print a, b
became:
print(a,b)
in Python < 3.0, that is printing out a tuple. The correct conversion is:
print("%s %s" % (a, b))
in many cases, A is a string, so a typical conversion might be:
print "Path:", foo
to:
print("Path: %s" % foo)
Cheers,
-g
On Sun, Sep 28, 2008 at 6:42 PM, Lieven Govaerts <sv...@mobsol.be> wrote:
> arfrever@tigris.org wrote:
>> Author: arfrever
>> Date: Sun Sep 28 08:06:24 2008
>> New Revision: 33335
>>
>> Log:
>> Python 3 compatibility:
>> Update calls to print() in 'build' directory, 'gen-make.py' and 'win-tests.py'.
>>
>> * build/generator/extractor.py:
>> * build/generator/gen_win.py:
>> * build/generator/swig/checkout_swig_header.py:
>> * build/generator/swig/external_runtime.py:
>> * build/generator/swig/header_wrappers.py:
>> * build/get-py-info.py:
>> * build/getversion.py:
>> * build/run_tests.py:
>> * build/strip-po-charset.py:
>> * build/win32/make_dist.py:
>> * gen-make.py:
>> * win-tests.py: Call print() or <file>.write().
>
> This change breaks the swig build on the Mac buildslave, which uses
> Python 2.3.5. I see that in some cases "()" characters are printed in
> the output.
>
> Example 1: Note the '()' around the gcc part.
> /bin/sh: -c: line 1: `/bin/sh
> /Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/libtool --tag=CC
> --silent --mode=compile ('gcc', '-fno-strict-aliasing -Wno-long-double
> -no-cpp-precomp -mno-fused-madd -fno-common -dynamic -DNDEBUG -g -O3
> -Wall -Wstrict-prototypes', '') -DDARWIN
> ..
> /bin/sh: -c: line 1: syntax error near unexpected token `('
>
> Example 2: 'print()' puts '()' on screen.
> lgomac:~/slavedir/osx10.4-gcc4.0.1-ia32/build lgo$ ./gen-make.py --help
> USAGE: gen-make.py [options...] [conf-file]
> -s skip dependency generation
> ..
> vcproj VC.Net project files
> ()
> The default generator type is 'make'
> ()
>
>
> Lieven
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org