[jira] [Comment Edited] (FLINK-27998) Upgrade Calcite version to 1.30

["Sergey Nuyanzin (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-27998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619272#comment-17619272 ] 

Sergey Nuyanzin edited comment on FLINK-27998 at 10/18/22 6:55 AM:
-------------------------------------------------------------------

Since it was suggested moving forward version by version may be it still makes sense to have it open?

P.S. by the way I have a draft PR to update to 1.32.0 passing Flink ci tests however probably it's easier especially for review to go step by step
https://github.com/apache/flink/pull/20922


was (Author: sergey nuyanzin):
Since it was suggested moving forward version by version may be it still makes sense to have it open?

P.S. by the way I have a draft PR to update to 1.32.0 which passing Flink ci tests however probably it's easier especially for review to go step by step
https://github.com/apache/flink/pull/20922

> Upgrade Calcite version to 1.30
> -------------------------------
>
>                 Key: FLINK-27998
>                 URL: https://issues.apache.org/jira/browse/FLINK-27998
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Table SQL / API, Table SQL / Runtime
>            Reporter: Martijn Visser
>            Priority: Major
>
> The latest available version of Calcite is currently 1.30. We already need to execute the rework that was planned when upgrading to Calcite 1.27 FLINK-20873 and when upgrading to Calcite 1.28 FLINK-21239
> When doing this upgrade, we should do this to the last available version. This is needed to resolve multiple bugs. 
> Additional note: Flink currently uses Calcite 1.26.0 which has this note on the release page:
> {{Warning: Calcite 1.26.0 has severe issues with RexNode simplification caused by SEARCH operator ( wrong data from query optimization like in CALCITE-4325, CALCITE-4352, NullPointerException), so use 1.26.0 for development only, and beware that Calcite 1.26.0 might corrupt your data.}}
> https://calcite.apache.org/news/2020/10/06/release-1.26.0/
> The following files should be removed from the Flink code base when upgrading calcite to 1.30.0
> in `org.apahce.calcite.rel.core`:
>  * Correlate
>  * Filter
>  * Intersect
>  * Minus
>  * SetOp
>  * Sort
>  * Union
>  * Values
>  * Window
> in `org.apahce.calcite.rel.hint`:
>  * HintPredicates
>  * NodeTypeHintPredicate
> in `org.apahce.calcite.rel.logical`:
>  * LogicalCorrelate
>  * LogicalFilter
>  * LogicalIntersect
>  * LogicalMinus
>  * LogicalSort
>  * LogicalUnion
>  * LogicalValues
>  * LogicalWindow



--
This message was sent by Atlassian Jira
(v8.20.10#820010)