You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@ambari.apache.org by Matt <mi...@gmail.com> on 2016/04/23 01:51:22 UTC

Review Request 46585: Show number of PXFs Live widget on main dashboard

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46585/
-----------------------------------------------------------

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, and Lav Jain.


Bugs: AMBARI-16074
    https://issues.apache.org/jira/browse/AMBARI-16074


Repository: ambari


Description
-------

Show number of PXFs Live widget on main dashboard


Diffs
-----

  ambari-web/app/assets/test/tests.js 33e7f1c 
  ambari-web/app/mappers/components_state_mapper.js 755c0f5 
  ambari-web/app/messages.js 907d9ae 
  ambari-web/app/views.js 6bb2774 
  ambari-web/app/views/main/dashboard/widgets.js 067607f 
  ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js bec98c6 
  ambari-web/app/views/main/dashboard/widgets/pxf_live.js PRE-CREATION 
  ambari-web/test/views/main/dashboard/widgets/pxf_live_test.js PRE-CREATION 

Diff: https://reviews.apache.org/r/46585/diff/


Testing
-------

Manually Tested

Added Unit test.

Unit test Results:

  27538 tests complete (22 seconds)
  154 tests pending
  
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:11 min
[INFO] Finished at: 2016-04-22T16:50:37-07:00
[INFO] Final Memory: 12M/310M
[INFO] ------------------------------------------------------------------------


Thanks,

Matt

Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

Posted by Goutam Tadi <go...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46585/#review130451
-----------------------------------------------------------


Ship it!




Ship It!

- Goutam Tadi


On April 22, 2016, 11:51 p.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46585/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 11:51 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16074
>     https://issues.apache.org/jira/browse/AMBARI-16074
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Show number of PXFs Live widget on main dashboard
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 33e7f1c 
>   ambari-web/app/mappers/components_state_mapper.js 755c0f5 
>   ambari-web/app/messages.js 907d9ae 
>   ambari-web/app/views.js 6bb2774 
>   ambari-web/app/views/main/dashboard/widgets.js 067607f 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js bec98c6 
>   ambari-web/app/views/main/dashboard/widgets/pxf_live.js PRE-CREATION 
>   ambari-web/test/views/main/dashboard/widgets/pxf_live_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46585/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested
> 
> Added Unit test.
> 
> Unit test Results:
> 
>   27538 tests complete (22 seconds)
>   154 tests pending
>   
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:11 min
> [INFO] Finished at: 2016-04-22T16:50:37-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

Posted by jun aoki <ju...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46585/#review130526
-----------------------------------------------------------


Ship it!




Ship It!

- jun aoki


On April 22, 2016, 11:51 p.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46585/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 11:51 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16074
>     https://issues.apache.org/jira/browse/AMBARI-16074
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Show number of PXFs Live widget on main dashboard
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 33e7f1c 
>   ambari-web/app/mappers/components_state_mapper.js 755c0f5 
>   ambari-web/app/messages.js 907d9ae 
>   ambari-web/app/views.js 6bb2774 
>   ambari-web/app/views/main/dashboard/widgets.js 067607f 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js bec98c6 
>   ambari-web/app/views/main/dashboard/widgets/pxf_live.js PRE-CREATION 
>   ambari-web/test/views/main/dashboard/widgets/pxf_live_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46585/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested
> 
> Added Unit test.
> 
> Unit test Results:
> 
>   27538 tests complete (22 seconds)
>   154 tests pending
>   
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:11 min
> [INFO] Finished at: 2016-04-22T16:50:37-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

Posted by Lav Jain <lj...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46585/#review130491
-----------------------------------------------------------


Ship it!




Ship It!

- Lav Jain


On April 22, 2016, 11:51 p.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46585/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 11:51 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16074
>     https://issues.apache.org/jira/browse/AMBARI-16074
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Show number of PXFs Live widget on main dashboard
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 33e7f1c 
>   ambari-web/app/mappers/components_state_mapper.js 755c0f5 
>   ambari-web/app/messages.js 907d9ae 
>   ambari-web/app/views.js 6bb2774 
>   ambari-web/app/views/main/dashboard/widgets.js 067607f 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js bec98c6 
>   ambari-web/app/views/main/dashboard/widgets/pxf_live.js PRE-CREATION 
>   ambari-web/test/views/main/dashboard/widgets/pxf_live_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46585/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested
> 
> Added Unit test.
> 
> Unit test Results:
> 
>   27538 tests complete (22 seconds)
>   154 tests pending
>   
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:11 min
> [INFO] Finished at: 2016-04-22T16:50:37-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

Posted by Matt <mi...@gmail.com>.


> On April 25, 2016, 5:12 p.m., jun aoki wrote:
> > ambari-web/app/views/main/dashboard/widgets/pxf_live.js, line 87
> > <https://reviews.apache.org/r/46585/diff/1/?file=1358236#file1358236line87>
> >
> >     How about ```isAnyMetricsNA()``` ?

Will keep it as is to follow same format as DATANODE and HAWQSEGMENT https://github.com/apache/ambari/blob/trunk/ambari-web/app/views/main/dashboard/widgets/datanode_live.js#L81


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46585/#review130523
-----------------------------------------------------------


On April 22, 2016, 4:51 p.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46585/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 4:51 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16074
>     https://issues.apache.org/jira/browse/AMBARI-16074
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Show number of PXFs Live widget on main dashboard
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 33e7f1c 
>   ambari-web/app/mappers/components_state_mapper.js 755c0f5 
>   ambari-web/app/messages.js 907d9ae 
>   ambari-web/app/views.js 6bb2774 
>   ambari-web/app/views/main/dashboard/widgets.js 067607f 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js bec98c6 
>   ambari-web/app/views/main/dashboard/widgets/pxf_live.js PRE-CREATION 
>   ambari-web/test/views/main/dashboard/widgets/pxf_live_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46585/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested
> 
> Added Unit test.
> 
> Unit test Results:
> 
>   27538 tests complete (22 seconds)
>   154 tests pending
>   
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:11 min
> [INFO] Finished at: 2016-04-22T16:50:37-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

Posted by jun aoki <ju...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46585/#review130523
-----------------------------------------------------------




ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js (line 41)
<https://reviews.apache.org/r/46585/#comment194292>

    nice that it is generalized.



ambari-web/app/views/main/dashboard/widgets/pxf_live.js (line 87)
<https://reviews.apache.org/r/46585/#comment194294>

    How about ```isAnyMetricsNA()``` ?


- jun aoki


On April 22, 2016, 11:51 p.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46585/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 11:51 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16074
>     https://issues.apache.org/jira/browse/AMBARI-16074
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Show number of PXFs Live widget on main dashboard
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 33e7f1c 
>   ambari-web/app/mappers/components_state_mapper.js 755c0f5 
>   ambari-web/app/messages.js 907d9ae 
>   ambari-web/app/views.js 6bb2774 
>   ambari-web/app/views/main/dashboard/widgets.js 067607f 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js bec98c6 
>   ambari-web/app/views/main/dashboard/widgets/pxf_live.js PRE-CREATION 
>   ambari-web/test/views/main/dashboard/widgets/pxf_live_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46585/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested
> 
> Added Unit test.
> 
> Unit test Results:
> 
>   27538 tests complete (22 seconds)
>   154 tests pending
>   
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:11 min
> [INFO] Finished at: 2016-04-22T16:50:37-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

Posted by bhuvnesh chaudhary <bc...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46585/#review130524
-----------------------------------------------------------


Ship it!




Ship It!

- bhuvnesh chaudhary


On April 22, 2016, 11:51 p.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46585/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 11:51 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16074
>     https://issues.apache.org/jira/browse/AMBARI-16074
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Show number of PXFs Live widget on main dashboard
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 33e7f1c 
>   ambari-web/app/mappers/components_state_mapper.js 755c0f5 
>   ambari-web/app/messages.js 907d9ae 
>   ambari-web/app/views.js 6bb2774 
>   ambari-web/app/views/main/dashboard/widgets.js 067607f 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js bec98c6 
>   ambari-web/app/views/main/dashboard/widgets/pxf_live.js PRE-CREATION 
>   ambari-web/test/views/main/dashboard/widgets/pxf_live_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46585/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested
> 
> Added Unit test.
> 
> Unit test Results:
> 
>   27538 tests complete (22 seconds)
>   154 tests pending
>   
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:11 min
> [INFO] Finished at: 2016-04-22T16:50:37-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Matt
> 
>