You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mingjie Lai (Created) (JIRA)" <ji...@apache.org> on 2012/03/03 02:31:03 UTC
[jira] [Created] (HBASE-5514) Minor fixes to compile against Hadoop
0.24-SNAPSHOT: replace deprecated Syncable.sync()
Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()
---------------------------------------------------------------------------------------
Key: HBASE-5514
URL: https://issues.apache.org/jira/browse/HBASE-5514
Project: HBase
Issue Type: Bug
Components: build, test
Affects Versions: 0.92.0, 0.94.0
Reporter: Mingjie Lai
Assignee: Mingjie Lai
Priority: Minor
Fix For: 0.94.0
HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop
0.24-SNAPSHOT
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225865#comment-13225865 ]
Hudson commented on HBASE-5514:
-------------------------------
Integrated in HBase-TRUNK-security #132 (See [https://builds.apache.org/job/HBase-TRUNK-security/132/])
HBASE-5514 Compile against hadoop 0.24-SNAPSHOT (Mingjie) (Revision 1298488)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/pom.xml
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
> Compile against hadoop 0.24-SNAPSHOT
> ------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514-4.patch, HBASE-5514.patch
>
>
> Need to compile hbase against the latest hadoop trunk which just had NN HA merged in.
> 1) add a hadoop 0.24 profile
> 2) HBASE-5480
> 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Minor fixes to compile against
Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221515#comment-13221515 ]
Zhihong Yu commented on HBASE-5514:
-----------------------------------
@Mingjie:
I am afraid you need to use reflection.
Compiling against hadoop 1.0 I saw:
{code}
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.0.2:testCompile (default-testCompile) on project hbase: Compilation failure: Compilation failure:
[ERROR] /Users/zhihyu/trunk-hbase/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java:[207,7] cannot find symbol
[ERROR] symbol : method hflush()
[ERROR] location: class org.apache.hadoop.fs.FSDataOutputStream
[ERROR]
[ERROR] /Users/zhihyu/trunk-hbase/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java:[1269,9] cannot find symbol
[ERROR] symbol : method hflush()
[ERROR] location: class org.apache.hadoop.fs.FSDataOutputStream
{code}
This is because Syncable interface is different between hadoop 1.0 and hadoop 0.22/0.23
> Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514.patch
>
>
> HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Minor fixes to compile against
Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221463#comment-13221463 ]
Zhihong Yu commented on HBASE-5514:
-----------------------------------
@Mingjie:
This issue is related to HBASE-5480
Can you generate patch with --no-prefix ?
> Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514.patch
>
>
> HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Minor fixes to compile against
Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221517#comment-13221517 ]
Zhihong Yu commented on HBASE-5514:
-----------------------------------
See the following example from src/main/java/org/apache/hadoop/hbase/util/FSUtils.java:
{code}
try {
FSDataOutputStream.class.getMethod("hflush", new Class<?> []{});
append = true;
} catch (NoSuchMethodException e) {
{code}
> Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514.patch
>
>
> HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5514) Minor fixes to compile against Hadoop
0.24-SNAPSHOT: replace deprecated Syncable.sync()
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5514:
------------------------------
Status: Open (was: Patch Available)
> Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514.patch
>
>
> HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop
0.24-SNAPSHOT
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225737#comment-13225737 ]
Hudson commented on HBASE-5514:
-------------------------------
Integrated in HBase-TRUNK #2674 (See [https://builds.apache.org/job/HBase-TRUNK/2674/])
HBASE-5514 Compile against hadoop 0.24-SNAPSHOT (Mingjie) (Revision 1298488)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/pom.xml
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
> Compile against hadoop 0.24-SNAPSHOT
> ------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514-4.patch, HBASE-5514.patch
>
>
> Need to compile hbase against the latest hadoop trunk which just had NN HA merged in.
> 1) add a hadoop 0.24 profile
> 2) HBASE-5480
> 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop
0.24-SNAPSHOT
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228117#comment-13228117 ]
Hudson commented on HBASE-5514:
-------------------------------
Integrated in HBase-0.94 #28 (See [https://builds.apache.org/job/HBase-0.94/28/])
HBASE-5514 Compile against hadoop 0.24-SNAPSHOT (Mingjie) (Revision 1299928)
Result = SUCCESS
tedyu :
Files :
* /hbase/branches/0.94/pom.xml
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
> Compile against hadoop 0.24-SNAPSHOT
> ------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514-4.patch, HBASE-5514.patch
>
>
> Need to compile hbase against the latest hadoop trunk which just had NN HA merged in.
> 1) add a hadoop 0.24 profile
> 2) HBASE-5480
> 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5514:
------------------------------
Hadoop Flags: Reviewed
Status: Patch Available (was: Open)
> Compile against hadoop 0.24-SNAPSHOT
> ------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514.patch
>
>
> Need to compile hbase against the latest hadoop trunk which just had NN HA merged in.
> 1) add a hadoop 0.24 profile
> 2) HBASE-5480
> 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5514) Minor fixes to compile against Hadoop
0.24-SNAPSHOT: replace deprecated Syncable.sync()
Posted by "Mingjie Lai (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingjie Lai updated HBASE-5514:
-------------------------------
Attachment: HBASE-5514.patch
Patch for trunk, 0.92.
> Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514.patch
>
>
> HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5514) Minor fixes to compile against Hadoop
0.24-SNAPSHOT: replace deprecated Syncable.sync()
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5514:
------------------------------
Status: Patch Available (was: Open)
> Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514.patch
>
>
> HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop
0.24-SNAPSHOT
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225338#comment-13225338 ]
Zhihong Yu commented on HBASE-5514:
-----------------------------------
TestSplitLogManager passed locally based on patch v4.
Integrated to TRUNK.
Thanks for the patch, Mingjie.
> Compile against hadoop 0.24-SNAPSHOT
> ------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514-4.patch, HBASE-5514.patch
>
>
> Need to compile hbase against the latest hadoop trunk which just had NN HA merged in.
> 1) add a hadoop 0.24 profile
> 2) HBASE-5480
> 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop
0.24-SNAPSHOT
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221912#comment-13221912 ]
Zhihong Yu commented on HBASE-5514:
-----------------------------------
Similar reflection code is introduced for both tests.
Can we extract the new code into a helper class or method in org.apache.hadoop.hbase.regionserver.wal package ?
{code}
+ if (syncMethod != null) {
+ syncMethod.invoke(out, new Object[]{});
+ }
{code}
Is the above check needed ? If getMethod() calls fail, there should be exception thrown that would fail the test.
> Compile against hadoop 0.24-SNAPSHOT
> ------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514.patch
>
>
> Need to compile hbase against the latest hadoop trunk which just had NN HA merged in.
> 1) add a hadoop 0.24 profile
> 2) HBASE-5480
> 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5514) Minor fixes to compile against Hadoop
0.24-SNAPSHOT: replace deprecated Syncable.sync()
Posted by "Mingjie Lai (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingjie Lai updated HBASE-5514:
-------------------------------
Attachment: HBASE-5514-2.patch
patch generated with --no-prefix
> Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514.patch
>
>
> HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop
0.24-SNAPSHOT
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222253#comment-13222253 ]
Hadoop QA commented on HBASE-5514:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517055/HBASE-5514-4.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 8 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -129 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 154 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestSplitLogManager
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestImportTsv
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1099//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1099//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1099//console
This message is automatically generated.
> Compile against hadoop 0.24-SNAPSHOT
> ------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514-4.patch, HBASE-5514.patch
>
>
> Need to compile hbase against the latest hadoop trunk which just had NN HA merged in.
> 1) add a hadoop 0.24 profile
> 2) HBASE-5480
> 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop
0.24-SNAPSHOT
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228062#comment-13228062 ]
Zhihong Yu commented on HBASE-5514:
-----------------------------------
Integrated to 0.94 branch now that HBASE-5480 has been integrated to 0.94
> Compile against hadoop 0.24-SNAPSHOT
> ------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514-4.patch, HBASE-5514.patch
>
>
> Need to compile hbase against the latest hadoop trunk which just had NN HA merged in.
> 1) add a hadoop 0.24 profile
> 2) HBASE-5480
> 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
Posted by "Mingjie Lai (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingjie Lai updated HBASE-5514:
-------------------------------
Attachment: HBASE-5514-3.patch
New patch:
- add 0.24 profile to pom.xml
- use reflection to determine which sync method to use in TestHLog and TestHLogSplit.
> Compile against hadoop 0.24-SNAPSHOT
> ------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514.patch
>
>
> Need to compile hbase against the latest hadoop trunk which just had NN HA merged in.
> 1) add a hadoop 0.24 profile
> 2) HBASE-5480
> 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
Posted by "Mingjie Lai (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingjie Lai updated HBASE-5514:
-------------------------------
Description:
Need to compile hbase against the latest hadoop trunk which just had NN HA merged in.
1) add a hadoop 0.24 profile
2) HBASE-5480
3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
was:HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
Summary: Compile against hadoop 0.24-SNAPSHOT (was: Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync())
@Zhihong, thanks for pointing it out. I thought hadoop hflush() was brought at 0.20, but actually 0.21.
As Zhihong mentioned, the scope is broader than I originally expected.
Rename the title from ``Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()'' -> ``Compile against hadoop 0.24-SNAPSHOT''.
> Compile against hadoop 0.24-SNAPSHOT
> ------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514.patch
>
>
> Need to compile hbase against the latest hadoop trunk which just had NN HA merged in.
> 1) add a hadoop 0.24 profile
> 2) HBASE-5480
> 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop
0.24-SNAPSHOT
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221923#comment-13221923 ]
Hadoop QA commented on HBASE-5514:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12516981/HBASE-5514-3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 8 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -129 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 154 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestImportTsv
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1090//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1090//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1090//console
This message is automatically generated.
> Compile against hadoop 0.24-SNAPSHOT
> ------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514.patch
>
>
> Need to compile hbase against the latest hadoop trunk which just had NN HA merged in.
> 1) add a hadoop 0.24 profile
> 2) HBASE-5480
> 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
Posted by "Mingjie Lai (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingjie Lai updated HBASE-5514:
-------------------------------
Attachment: HBASE-5514-4.patch
Per Ted's request: removed the redundant null check.
> Can we extract the new code into a helper class or method in org.apache.hadoop.hbase.regionserver.wal package ?
It only occurs for 2 test cases, and the code duplication is quite small. Do you really think we should have one method to cover them?
> Compile against hadoop 0.24-SNAPSHOT
> ------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514-4.patch, HBASE-5514.patch
>
>
> Need to compile hbase against the latest hadoop trunk which just had NN HA merged in.
> 1) add a hadoop 0.24 profile
> 2) HBASE-5480
> 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5514:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Compile against hadoop 0.24-SNAPSHOT
> ------------------------------------
>
> Key: HBASE-5514
> URL: https://issues.apache.org/jira/browse/HBASE-5514
> Project: HBase
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514-4.patch, HBASE-5514.patch
>
>
> Need to compile hbase against the latest hadoop trunk which just had NN HA merged in.
> 1) add a hadoop 0.24 profile
> 2) HBASE-5480
> 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira