[kudu] branch master updated: [java] Remove PMD static analysis

[gr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new 3d57198  [java] Remove PMD static analysis
3d57198 is described below

commit 3d57198663f3ed6980f4d92720963ddd0f3a1471
Author: Grant Henke <gr...@apache.org>
AuthorDate: Mon Nov 25 12:04:52 2019 -0600

    [java] Remove PMD static analysis
    
    This patch removes the PMD static analysis from the Gradle build.
    PMD adds the the build runtime with little to no added value given
    we have thorough static coverage with Checkstyle, ErrorProne, and
    SpotBugs.
    
    Change-Id: If454b4195c987a15b9c07aceef04f028ab1496d5
    Reviewed-on: http://gerrit.cloudera.org:8080/14796
    Tested-by: Kudu Jenkins
    Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
 java/gradle/dependencies.gradle |  1 -
 java/gradle/quality.gradle      | 12 ------------
 2 files changed, 13 deletions(-)

diff --git a/java/gradle/dependencies.gradle b/java/gradle/dependencies.gradle
index 3334c1a..76cc8cd 100755
--- a/java/gradle/dependencies.gradle
+++ b/java/gradle/dependencies.gradle
@@ -50,7 +50,6 @@ versions += [
     netty          : "3.10.6.Final",
     osdetector     : "1.6.2",
     parquet        : "1.10.1",
-    pmd            : "5.8.1",
     protobuf       : "3.10.0",
     scala          : "2.11.12",
     scalatest      : "3.0.8",
diff --git a/java/gradle/quality.gradle b/java/gradle/quality.gradle
index 8db0798..1d36919 100644
--- a/java/gradle/quality.gradle
+++ b/java/gradle/quality.gradle
@@ -19,7 +19,6 @@
 
 apply plugin: "checkstyle" // Ensures Java code follows the defined coding style.
 apply plugin: "com.github.spotbugs"   // Performs static code analysis to look for bugs in Java code.
-apply plugin: "pmd"        // Performs static code analysis to look for common code smells in Java code.
 apply plugin: "com.github.ben-manes.versions" // Provides a task to determine which dependencies have updates.
 apply plugin: "ru.vyarus.animalsniffer" // Ensures Java code uses APIs from a particular version of Java.
 apply plugin: "scalafmt" // Automatically formats Scala code on each build.
@@ -59,11 +58,6 @@ task spotbugs(dependsOn: [spotbugsMain, spotbugsTest], group: "Verification") {
   description = "Run SpotBugs analysis."
 }
 
-pmd {
-  toolVersion = versions.pmd
-  ignoreFailures = true
-}
-
 scalafmt {
   configFilePath = "$rootDir/.scalafmt.conf"
 }
@@ -75,12 +69,6 @@ tasks.withType(ScalaCompile) {
   }
 }
 
-// Create an aggregate pmd task.
-// This simplifies running pmd on all the code by only needing one task instead of multiple in your command.
-task pmd(dependsOn: [pmdMain, pmdTest], group: "Verification") {
-  description = "Run PMD analysis."
-}
-
 // Configure error-prone.
 // Running with '-Derrorprone-fix=...' can instruct error-prone to automatically fix issues.
 tasks.withType(JavaCompile) {