You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/03/11 22:39:32 UTC
[kudu-CR] [tablet] add tablet id into trace of a slow write op
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18315
Change subject: [tablet] add tablet_id into trace of a slow write op
......................................................................
[tablet] add tablet_id into trace of a slow write op
While troubleshooting one performance issue, I found that the traces
on long running write operations didn't contain information on their
tablet identifier.
This patch address that, so now it's easier to tell what's the tablet
where write operations run longer. I also took the liberty to update
the code around, making the style of the trace messages more uniform.
Change-Id: I06b05e8be1f5376b60244228809be9d260ed8398
---
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
2 files changed, 20 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/18315/1
--
To view, visit http://gerrit.cloudera.org:8080/18315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I06b05e8be1f5376b60244228809be9d260ed8398
Gerrit-Change-Number: 18315
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [tablet] add tablet id into trace of a slow write op
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18315 )
Change subject: [tablet] add tablet_id into trace of a slow write op
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06b05e8be1f5376b60244228809be9d260ed8398
Gerrit-Change-Number: 18315
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 14 Mar 2022 22:14:28 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] add tablet id into trace of a slow write op
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18315 )
Change subject: [tablet] add tablet_id into trace of a slow write op
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18315/1/src/kudu/tablet/ops/write_op.cc
File src/kudu/tablet/ops/write_op.cc:
http://gerrit.cloudera.org:8080/#/c/18315/1/src/kudu/tablet/ops/write_op.cc@164
PS1, Line 164:
> nit: Something like "Starting on tablet <tablet_id>" might be clearer than
Done
--
To view, visit http://gerrit.cloudera.org:8080/18315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06b05e8be1f5376b60244228809be9d260ed8398
Gerrit-Change-Number: 18315
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 14 Mar 2022 17:04:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tablet] add tablet id into trace of a slow write op
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18315 )
Change subject: [tablet] add tablet_id into trace of a slow write op
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18315/1/src/kudu/tablet/ops/write_op.cc
File src/kudu/tablet/ops/write_op.cc:
http://gerrit.cloudera.org:8080/#/c/18315/1/src/kudu/tablet/ops/write_op.cc@164
PS1, Line 164:
nit: Something like "Starting on tablet <tablet_id>" might be clearer than "Starting tablet <tablet_id>"
--
To view, visit http://gerrit.cloudera.org:8080/18315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06b05e8be1f5376b60244228809be9d260ed8398
Gerrit-Change-Number: 18315
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 14 Mar 2022 16:33:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tablet] add tablet id into trace of a slow write op
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18315
to look at the new patch set (#2).
Change subject: [tablet] add tablet_id into trace of a slow write op
......................................................................
[tablet] add tablet_id into trace of a slow write op
While troubleshooting one performance issue, I found that the traces
on long running write operations didn't contain information on their
tablet identifier.
This patch address that, so now it's easier to tell what's the tablet
where write operations run longer. I also took the liberty to update
the code around, making the style of the trace messages more uniform.
Change-Id: I06b05e8be1f5376b60244228809be9d260ed8398
---
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
2 files changed, 20 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/18315/2
--
To view, visit http://gerrit.cloudera.org:8080/18315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I06b05e8be1f5376b60244228809be9d260ed8398
Gerrit-Change-Number: 18315
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [tablet] add tablet id into trace of a slow write op
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18315 )
Change subject: [tablet] add tablet_id into trace of a slow write op
......................................................................
[tablet] add tablet_id into trace of a slow write op
While troubleshooting one performance issue, I found that the traces
on long running write operations didn't contain information on their
tablet identifier.
This patch address that, so now it's easier to tell what's the tablet
where write operations run longer. I also took the liberty to update
the code around, making the style of the trace messages more uniform.
Change-Id: I06b05e8be1f5376b60244228809be9d260ed8398
Reviewed-on: http://gerrit.cloudera.org:8080/18315
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
2 files changed, 20 insertions(+), 19 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I06b05e8be1f5376b60244228809be9d260ed8398
Gerrit-Change-Number: 18315
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)