You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by sh...@apache.org on 2023/04/05 16:05:11 UTC

[daffodil-vscode] branch main updated: Clear selection data when ephemeral windows close

This is an automated email from the ASF dual-hosted git repository.

shanedell pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/daffodil-vscode.git


The following commit(s) were added to refs/heads/main by this push:
     new f7cfe93  Clear selection data when ephemeral windows close
f7cfe93 is described below

commit f7cfe93812394f6f917e52623251e9a66b74a6bc
Author: Robert Strickland <st...@gmail.com>
AuthorDate: Wed Apr 5 09:06:31 2023 -0500

    Clear selection data when ephemeral windows close
    
    - Lingering selection data, especially in SBM, would cause issues when
      trying to search / replace.
    
    Closes #561
---
 src/svelte/src/components/dataEditor.svelte | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/svelte/src/components/dataEditor.svelte b/src/svelte/src/components/dataEditor.svelte
index 66f0abf..6362994 100644
--- a/src/svelte/src/components/dataEditor.svelte
+++ b/src/svelte/src/components/dataEditor.svelte
@@ -220,6 +220,7 @@ limitations under the License.
         (targetLine == 0 ? 0 : targetLine - 1) * lineHeight
     }
     closeEphemeralWindows()
+    clearDataDisplays()
   }
 
   function goToEventHandler(_: Event) {
@@ -540,6 +541,8 @@ limitations under the License.
       },
     })
     $searching = true
+    closeEphemeralWindows()
+    clearDataDisplays()
   }
 
   function searchAndReplace() {
@@ -555,6 +558,8 @@ limitations under the License.
       },
     })
     $replacing = true
+    closeEphemeralWindows()
+    clearDataDisplays()
   }
 
   function saveToDisk() {