You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/01/26 05:03:51 UTC
Review Request 55978: Added some assertions to the switchboard request
handler.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55978/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-6936
https://issues.apache.org/jira/browse/MESOS-6936
Repository: mesos
Description
-------
Some of the request parameters e.g., request method/header values
are already validated by the agent. We can replace them with explicit
assertions in the IO switchboard.
Diffs
-----
src/slave/containerizer/mesos/io/switchboard.cpp 1b8f490872b8a13dc7bc64883ed28080752f82b6
Diff: https://reviews.apache.org/r/55978/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 55978: Added some assertions to the switchboard
request handler.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55978/#review163342
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 26, 2017, 5:03 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55978/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 5:03 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6936
> https://issues.apache.org/jira/browse/MESOS-6936
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some of the request parameters e.g., request method/header values
> are already validated by the agent. We can replace them with explicit
> assertions in the IO switchboard.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.cpp 1b8f490872b8a13dc7bc64883ed28080752f82b6
>
> Diff: https://reviews.apache.org/r/55978/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>