You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by birge <gi...@git.apache.org> on 2016/01/19 19:39:49 UTC
[GitHub] cordova-plugin-inappbrowser pull request: Add fix for iOS file upl...
GitHub user birge opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/139
Add fix for iOS file upload.
I'd like to start by saying I don't understand fully what the issue is or how this fixes the issue. I have been having an issue where my cordova app would fall back to the splash screen when I tried to upload a file on iOS. I found the solution here https://issues.apache.org/jira/browse/CB-7679
This is before the fix
and this is after
I am not sure why this fix wasn't already included so I am hoping it just because no one has taken the time to make a PR. Any issues with this?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/birge/cordova-plugin-inappbrowser master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/139.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #139
----
commit 651d3cdff3446c7fe16ab3ed866fd194c6f7fd97
Author: Birge Clark <bi...@zendesk.com>
Date: 2016-01-19T18:31:28Z
add fix for iOS upload
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Add fix for iOS file upl...
Posted by worsection <gi...@git.apache.org>.
Github user worsection commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/139#issuecomment-200051123
Will you add this fix or any alternative to fix ios file upload?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Add fix for iOS file upl...
Posted by hkjorgensen <gi...@git.apache.org>.
Github user hkjorgensen commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/139#issuecomment-176511074
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Add fix for iOS file upl...
Posted by firepol <gi...@git.apache.org>.
Github user firepol commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/139#issuecomment-197362370
This should be definitively in. I created a fork, modified the file as birge did and installed from my modified repo. Would have been nicer taking this from the official repo...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Add fix for iOS file upl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Add fix for iOS file upl...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/139#issuecomment-200816701
Thanks for the pull request. I've had a look at it and think it looks good. Before we can merge it though, you need to sign Apache's Contributor License Agreement (can be done online): http://www.apache.org/licenses/#clas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Add fix for iOS file upl...
Posted by spedmo <gi...@git.apache.org>.
Github user spedmo commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/139#issuecomment-186174071
Why isnt this in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org