You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/06/26 18:02:32 UTC
[kudu-CR](branch-1.10.x) [tablet] reinforce the CountLiveRows API
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13741
Change subject: [tablet] reinforce the CountLiveRows API
......................................................................
[tablet] reinforce the CountLiveRows API
In the recent patch 13426, I found that the CountLiveRows API is
not safe after the tablet is been shut down. Though the API has
not been used by any real users except test cases, I think it's
necessary to add this patch to the 1.10.x release in progress if
it's possible.
Change-Id: I56b25a6acb61564ce089be11a1605a19c25eb9e0
Reviewed-on: http://gerrit.cloudera.org:8080/13734
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 30b88b464f0b13ede2099832d40f50f4ed4a1b1b)
---
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
2 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/13741/1
--
To view, visit http://gerrit.cloudera.org:8080/13741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56b25a6acb61564ce089be11a1605a19c25eb9e0
Gerrit-Change-Number: 13741
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
[kudu-CR](branch-1.10.x) [tablet] reinforce the CountLiveRows API
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13741 )
Change subject: [tablet] reinforce the CountLiveRows API
......................................................................
[tablet] reinforce the CountLiveRows API
In the recent patch 13426, I found that the CountLiveRows API is
not safe after the tablet is been shut down. Though the API has
not been used by any real users except test cases, I think it's
necessary to add this patch to the 1.10.x release in progress if
it's possible.
Change-Id: I56b25a6acb61564ce089be11a1605a19c25eb9e0
Reviewed-on: http://gerrit.cloudera.org:8080/13734
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 30b88b464f0b13ede2099832d40f50f4ed4a1b1b)
Reviewed-on: http://gerrit.cloudera.org:8080/13741
---
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
2 files changed, 21 insertions(+), 0 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I56b25a6acb61564ce089be11a1605a19c25eb9e0
Gerrit-Change-Number: 13741
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
[kudu-CR](branch-1.10.x) [tablet] reinforce the CountLiveRows API
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13741 )
Change subject: [tablet] reinforce the CountLiveRows API
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I56b25a6acb61564ce089be11a1605a19c25eb9e0
Gerrit-Change-Number: 13741
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 18:24:53 +0000
Gerrit-HasComments: No