[jira] [Commented] (AIRFLOW-6787) Make ClientRequestToken Optional

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035699#comment-17035699 ] 

ASF GitHub Bot commented on AIRFLOW-6787:
-----------------------------------------

lindsable commented on pull request #7408: [AIRFLOW-6787] make ClientRequestToken optional
URL: https://github.com/apache/airflow/pull/7408
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   https://issues.apache.org/jira/browse/AIRFLOW-6787
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make ClientRequestToken Optional
> --------------------------------
>
>                 Key: AIRFLOW-6787
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6787
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: aws, hooks
>    Affects Versions: 1.10.8, 1.10.9
>            Reporter: Lindsay Portelli
>            Priority: Minor
>
> Boto3 doesn't accept parameters that are None so if you want to use AWSAthenaHook.run_query you must pass in a client_request_token.
> You can see the documentation on this parameter [https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/athena.html?highlight=start_query_execution#Athena.Client.start_query_execution]
> and note that if it is not provided it will be automatically generated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)