[GitHub] [phoenix] kadirozde commented on a change in pull request #624: PHOENIX-5564 Restructure read repair to improve readability and corre…

[GitBox <gi...@apache.org>]

kadirozde commented on a change in pull request #624: PHOENIX-5564 Restructure read repair to improve readability and corre…
URL: https://github.com/apache/phoenix/pull/624#discussion_r344867842
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java
 ##########
 @@ -322,28 +370,19 @@ private void repairIndexRows(byte[] indexRowKey, long ts, List<Cell> row) throws
                 singleRowScanner.next(row);
                 singleRowScanner.close();
                 if (row.isEmpty()) {
-                    // This means that the data row did not exist, so we need to skip this unverified row (i.e., do not
-                    // return it to the client). Just retuning empty row is sufficient to do that
-                    return;
+                    throw new DoNotRetryIOException("Could not find the newly rebuilt index row " +
 
 Review comment:
   This and the previous exception are to catch "impossible" cases. Now that you asked, I want to check more time if they really cannot happen. Maybe logging error and skipping could be safer as you suggested.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services