[jira] [Commented] (FOP-2785) inconsistent method name "make"

["KuiLIU (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FOP-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440786#comment-16440786 ] 

KuiLIU commented on FOP-2785:
-----------------------------

https://github.com/apache/fop/pull/6/files

> inconsistent method name "make"
> -------------------------------
>
>                 Key: FOP-2785
>                 URL: https://issues.apache.org/jira/browse/FOP-2785
>             Project: FOP
>          Issue Type: Improvement
>    Affects Versions: trunk
>            Reporter: KuiLIU
>            Priority: Major
>
> The method seems to find an appropriate "Property" related to the fo.getNameId().
> Thus, identifier "find" should be better than "make".
> {code:java}
>    /**
>      * Set default precedence according to the parent FObj
>      *
>      * {@inheritDoc}
>      */
>      public Property make(PropertyList propertyList) throws PropertyException {
>          FObj fo = propertyList.getFObj();
>          switch (fo.getNameId()) {
>          case Constants.FO_TABLE:
>              return num6;
>          case Constants.FO_TABLE_CELL:
>              return num5;
>          case Constants.FO_TABLE_COLUMN:
>              return num4;
>          case Constants.FO_TABLE_ROW:
>              return num3;
>          case Constants.FO_TABLE_BODY:
>              return num2;
>          case Constants.FO_TABLE_HEADER:
>              return num1;
>          case Constants.FO_TABLE_FOOTER:
>              return num0;
>          default:
>              return null;
>          }
>      }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)