You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/05/04 21:00:07 UTC

[GitHub] [james-project] mbaechler opened a new pull request, #984: JAMES-3759 Fix typo and enable leak detector for real

mbaechler opened a new pull request, #984:
URL: https://github.com/apache/james-project/pull/984

   Co-Authored-By: Jean Helou <je...@gmail.com>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] vttranlina commented on pull request #984: JAMES-3759 Fix typo and enable leak detector for real

Posted by GitBox <gi...@apache.org>.
vttranlina commented on PR #984:
URL: https://github.com/apache/james-project/pull/984#issuecomment-1118121125

   After fixing the typo, we will get ci fail. 
   Maybe it is related https://github.com/apache/james-project/pull/940#issuecomment-1085518526


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] mbaechler commented on pull request #984: JAMES-3759 Fix typo and enable leak detector for real

Posted by GitBox <gi...@apache.org>.
mbaechler commented on PR #984:
URL: https://github.com/apache/james-project/pull/984#issuecomment-1118241199

   > After fixing the typo, we will get ci fail. Maybe it is related [#940 (comment)](https://github.com/apache/james-project/pull/940#issuecomment-1085518526)
   
   Yes, it's why I opened https://issues.apache.org/jira/projects/JAMES/issues/JAMES-3760


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #984: JAMES-3759 Fix typo and enable leak detector for real

Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #984:
URL: https://github.com/apache/james-project/pull/984#issuecomment-1231779176

   Early detection is the reason we activated it in tests, but in the middle of the flood we will not notice anything, thus as of today early detection in build seems like a non reached objective to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #984: JAMES-3759 Fix typo and enable leak detector for real

Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #984:
URL: https://github.com/apache/james-project/pull/984#issuecomment-1120544526

   That is a question that I asked on JIRA but I got no answer.
   
   From what it seems, at least on james-core where this build fails, we are mostly testing how tests manages mails, and not really james itself. It's likely long to fix for limited benefits.
   
   How about activating leak detection in only strategically chosen projects like integration tests instead?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] jeantil closed pull request #984: JAMES-3759 Fix typo and enable leak detector for real

Posted by GitBox <gi...@apache.org>.
jeantil closed pull request #984: JAMES-3759 Fix typo and enable leak detector for real
URL: https://github.com/apache/james-project/pull/984


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #984: JAMES-3759 Fix typo and enable leak detector for real

Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #984:
URL: https://github.com/apache/james-project/pull/984#issuecomment-1231776649

   Well any places that creates a mail is suspicious IMO. Hard to say "that stack is okish, that one's not".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #984: JAMES-3759 Fix typo and enable leak detector for real

Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #984:
URL: https://github.com/apache/james-project/pull/984#issuecomment-1231269835

   Is there any plan to carry on this work?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] jeantil commented on pull request #984: JAMES-3759 Fix typo and enable leak detector for real

Posted by GitBox <gi...@apache.org>.
jeantil commented on PR #984:
URL: https://github.com/apache/james-project/pull/984#issuecomment-1231593660

   That's not to be answered by the authors of the PR I'm afraid. I still think the current situation is bad: 
   - the build files contain senseless configuration with typos
   - contributors and the CI log warnings in every tests we run because that's the default policy when the detector is left unconfigured
   
   In https://issues.apache.org/jira/projects/JAMES/issues/JAMES-3760 you suggest disabling the leak detector entirely to which I answered that this would prevent early detection of new leaks in production code.
   I am not familiar enough with the leak detector code and how it works but would it be possible to have a whitelist of sources for which leaks are ok and then actually fix the problem ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #984: JAMES-3759 Fix typo and enable leak detector for real

Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #984:
URL: https://github.com/apache/james-project/pull/984#issuecomment-1231774479

   Agreed, i'm in favor of fixing the typo and turning off leak detection in tests to not be flooded as we do not achieve good resource management in our tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #984: JAMES-3759 Fix typo and enable leak detector for real

Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #984:
URL: https://github.com/apache/james-project/pull/984#issuecomment-1232355318

   https://github.com/apache/james-project/pull/1170


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org