You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/19 05:29:38 UTC
[GitHub] [spark] jiangxb1987 commented on issue #24618:
[SPARK-27734][CORE][SQL] Add memory based thresholds for shuffle spill
jiangxb1987 commented on issue #24618: [SPARK-27734][CORE][SQL] Add memory based thresholds for shuffle spill
URL: https://github.com/apache/spark/pull/24618#issuecomment-600996032
This PR looks pretty good, it would be great if we can add some new benchmark case to ensure it doesn't bring in performance regression if config values are properly chosen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org