You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by cshannon <gi...@git.apache.org> on 2017/08/08 17:10:28 UTC
[GitHub] activemq-artemis pull request #1450: ARTEMIS-1332 - Always return a response...
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1450
ARTEMIS-1332 - Always return a response to the client on session
metadata add
This will make sure that if there is an ActiveMQException thrown the
client will get notified and not hang.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1332
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1450.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1450
----
commit 2cd3d5948675ccb550a87067bffbf74f1169043d
Author: Christopher L. Shannon (cshannon) <ch...@gmail.com>
Date: 2017-08-08T17:09:03Z
ARTEMIS-1332 - Always return a response to the client on session
metadata add
This will make sure that if there is an ActiveMQException thrown the
client will get notified and not hang.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1450: ARTEMIS-1332 - Always return a response...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1450
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1450: ARTEMIS-1332 - Always return a response to the...
Posted by cshannon <gi...@git.apache.org>.
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1450
@clebertsuconic - no problem that works
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1450: ARTEMIS-1332 - Always return a response to the...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1450
@cshannon only thing was the first line.. I merged the two first lines with an amend before merge.. I hope you won't mind.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1450: ARTEMIS-1332 - Always return a response to the...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1450
@cshannon I could have asked you to do it.. but thought it was an easy fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1450: ARTEMIS-1332 - Always return a response to the...
Posted by cshannon <gi...@git.apache.org>.
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1450
@clebertsuconic - is this ok to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1450: ARTEMIS-1332 - Always return a response to the...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1450
@cshannon ahaaa!!! thanks a lot... you just saved me a task ! 👍
Someone reported me an issue at Red Hat.. I think this is the cause.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---