[GitHub] [metron] mmiklavc commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch

[GitBox <gi...@apache.org>]

mmiklavc commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch
URL: https://github.com/apache/metron/pull/1497#issuecomment-528055572
 
 
   @nickwallen I stepped through the list of commits per your PR description and it looks reasonable to me except for one minor line difference for the revert of 1456. I had to check the reverts from the CLI because github seems to want to only do the full rollup from the browser regardless of which commit I'm inspecting. *Shrug*. 1456 shows "+1,374 −303" but the stat from the revert commit shows 1359 deletions. It looks like we're off by 15 lines. Any idea why that is?
   ```
   # PR 1458
   git show --stat 520998f1b
   ...
    37 files changed, 1332 insertions(+), 1461 deletions(-)
   # PR 1457
   git show --stat c62532a4b
   ...
   43 files changed, 715 insertions(+), 2018 deletions(-)
   # PR 1456
   git show --stat d07bb7b42
   ...
   23 files changed, 303 insertions(+), 1359 deletions(-)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services