You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@slider.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/03/08 17:25:38 UTC
[jira] [Commented] (SLIDER-1217) Coverity scan issue identified
with SLIDER-1214's commit
[ https://issues.apache.org/jira/browse/SLIDER-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901609#comment-15901609 ]
ASF subversion and git services commented on SLIDER-1217:
---------------------------------------------------------
Commit 150a31cfd0307bea9676a57ff83d1b90d7a89ff1 in incubator-slider's branch refs/heads/develop from [~gsaha]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-slider.git;h=150a31c ]
SLIDER-1217 Coverity scan issue identified with SLIDER-1214's commit
> Coverity scan issue identified with SLIDER-1214's commit
> --------------------------------------------------------
>
> Key: SLIDER-1217
> URL: https://issues.apache.org/jira/browse/SLIDER-1217
> Project: Slider
> Issue Type: Sub-task
> Components: appmaster, client
> Reporter: Gour Saha
> Assignee: Gour Saha
> Fix For: Slider 0.92
>
>
> Coverity scan identified the following defect which was added as part of SLIDER-1214's commit -
> {noformat}
> *** CID 142179: Concurrent data access violations (GUARDED_BY_VIOLATION)
> /slider-core/src/main/java/org/apache/slider/server/appmaster/state/AppState.java: 2621 in org.apache.slider.server.appmaster.state.AppState.storeContainerDiagnostics(java.lang.String, int, java.lang.String, int, java.lang.String, long)()
> 2615 containerInfo.exitCode = exitCode;
> 2616 if (StringUtils.isNotBlank(diagnostics)) {
> 2617 containerInfo.diagnostics = diagnostics;
> 2618 }
> 2619 containerInfo.state = state;
> 2620 if (logLink != null) {
> CID 142179: Concurrent data access violations (GUARDED_BY_VIOLATION)
> Accessing "containerInfo.logServerLogLink" without holding lock "AppState.this". Elsewhere, "org.apache.slider.api.types.ContainerInformation.logServerLogLink" is accessed with "AppState.this" held 2 out of 3 times.
> 2621 containerInfo.logServerLogLink = logLink;
> 2622 }
> 2623 containerInfo.completionTime = completionTime;
> 2624 }
> 2625 }
> 2626
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)