You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/13 07:29:38 UTC

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4283: Finish LIMIT for postgreSQL for visitor

terrymanu opened a new pull request #4283: Finish LIMIT for postgreSQL for visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4283
 
 
   For #4271.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4283: Finish LIMIT for postgreSQL for visitor

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4283: Finish LIMIT for postgreSQL for visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4283
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4283: Finish LIMIT for postgreSQL for visitor

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4283: Finish LIMIT for postgreSQL for visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4283#issuecomment-585598809
 
 
   ## Pull Request Test Coverage Report for [Build 1707](https://coveralls.io/builds/28705115)
   
   * **0** of **16**   **(0.0%)**  changed or added relevant lines in **2** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.04%**) to **63.018%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://coveralls.io/builds/28705115/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDMLVisitor.java#L466) | 0 | 3 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28705115/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L409) | 0 | 13 | 0.0%
   <!-- | **Total:** | **0** | **16** | **0.0%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28705115/badge)](https://coveralls.io/builds/28705115) |
   | :-- | --: |
   | Change from base [Build 839](https://coveralls.io/builds/28704139): |  -0.04% |
   | Covered Lines: | 11008 |
   | Relevant Lines: | 17468 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4283: Finish LIMIT for postgreSQL for visitor

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4283: Finish LIMIT for postgreSQL for visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4283#issuecomment-585597078
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4283?src=pr&el=h1) Report
   > Merging [#4283](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4283?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/87d6bd63aa411db99971c297eb257a42e0c72984?src=pr&el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4283/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4283?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4283      +/-   ##
   ============================================
   - Coverage     59.27%   59.19%   -0.08%     
     Complexity      352      352              
   ============================================
     Files          1018     1018              
     Lines         17446    17468      +22     
     Branches       3111     3118       +7     
   ============================================
     Hits          10341    10341              
   - Misses         6450     6472      +22     
     Partials        655      655
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4283?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...phere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4283/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9NeVNRTERNTFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4283/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvdmlzaXRvci9pbXBsL1Bvc3RncmVTUUxETUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4283?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4283?src=pr&el=footer). Last update [87d6bd6...af4c50a](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4283?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4283: Finish LIMIT for postgreSQL for visitor

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4283: Finish LIMIT for postgreSQL for visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4283#issuecomment-585598809
 
 
   ## Pull Request Test Coverage Report for [Build 9498](https://coveralls.io/builds/28705042)
   
   * **0** of **16**   **(0.0%)**  changed or added relevant lines in **2** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.05%**) to **63.007%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://coveralls.io/builds/28705042/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDMLVisitor.java#L466) | 0 | 3 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28705042/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L409) | 0 | 13 | 0.0%
   <!-- | **Total:** | **0** | **16** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28705042/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28705042/badge)](https://coveralls.io/builds/28705042) |
   | :-- | --: |
   | Change from base [Build 839](https://coveralls.io/builds/28704139): |  -0.05% |
   | Covered Lines: | 11006 |
   | Relevant Lines: | 17468 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services