You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/17 20:49:46 UTC

[GitHub] [airflow] Diogo-Costa opened a new pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

Diogo-Costa opened a new pull request #17666:
URL: https://github.com/apache/airflow/pull/17666


   Description
   It is not possible to create the service type "LoadBalancer" with option loadBalancerSourceRanges
   
   Use case / motivation
   When created webserver service with type "LoadBalancer" this value is "0.0.0.0/0" per default, In order to limit which client IP's can access the Load Balancer, we can specify loadBalancerSourceRanges.
   
   related: #17660
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on a change in pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

Posted by GitBox <gi...@apache.org>.

jedcunningham commented on a change in pull request #17666:
URL: https://github.com/apache/airflow/pull/17666#discussion_r690778830



##########
File path: chart/values.schema.json
##########
@@ -1818,6 +1818,12 @@
                             ],
                             "default": null
                         }
+                        },
+                        "loadBalancerSourceRanges": {
+                            "description": "Webserver Service loadBalancerSourceRanges.",
+                            "type": "array",
+                            "default": []

Review comment:
       ```suggestion
                               "default": [],
                               "examples": [
                                   "143.231.0.0/16"
                               ]
   ```

##########
File path: chart/templates/webserver/webserver-service.yaml
##########
@@ -51,3 +51,9 @@ spec:
   {{- if .Values.webserver.service.loadBalancerIP }}
   loadBalancerIP: {{ .Values.webserver.service.loadBalancerIP }}
   {{- end }}
+  {{- if .Values.service.loadBalancerSourceRanges }}
+  loadBalancerSourceRanges:
+  {{- range $cidr := .Values.service.loadBalancerSourceRanges }}
+    - {{ $cidr }}
+  {{- end }}

Review comment:
       ```suggestion
     {{- toYaml .Values.service.loadBalancerSourceRanges | nindent 4 }}
   ```
   
   I think this is cleaner?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Diogo-Costa commented on a change in pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

Posted by GitBox <gi...@apache.org>.

Diogo-Costa commented on a change in pull request #17666:
URL: https://github.com/apache/airflow/pull/17666#discussion_r692173624



##########
File path: chart/values.yaml
##########
@@ -701,6 +701,10 @@ webserver:
     #     port: 80
     #     targetPort: 8888
     loadBalancerIP: ~
+    ## Limit load balancer source ips to list of CIDRs
+    # loadBalancerSourceRanges:
+    #   - "143.231.0.0/16"

Review comment:
       I put it only at example, fixing this in next commit




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #17666:
URL: https://github.com/apache/airflow/pull/17666#issuecomment-902789138


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on a change in pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

Posted by GitBox <gi...@apache.org>.

jedcunningham commented on a change in pull request #17666:
URL: https://github.com/apache/airflow/pull/17666#discussion_r691547878



##########
File path: chart/values.yaml
##########
@@ -701,6 +701,10 @@ webserver:
     #     port: 80
     #     targetPort: 8888
     loadBalancerIP: ~
+    ## Limit load balancer source ips to list of CIDRs
+    # loadBalancerSourceRanges:
+    #   - "143.231.0.0/16"

Review comment:
       ```suggestion
       #   - "10.123.0.0/16"
   ```
   
   Thoughts on the examples being a private block instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #17666:
URL: https://github.com/apache/airflow/pull/17666#issuecomment-902839309


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #17666:
URL: https://github.com/apache/airflow/pull/17666#issuecomment-900620417

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham merged pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

Posted by GitBox <gi...@apache.org>.

jedcunningham merged pull request #17666:
URL: https://github.com/apache/airflow/pull/17666


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

Posted by GitBox <gi...@apache.org>.

jedcunningham commented on pull request #17666:
URL: https://github.com/apache/airflow/pull/17666#issuecomment-902839986


   Thanks @Diogo-Costa for the contribution, and congrats on your first commit!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on a change in pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

Posted by GitBox <gi...@apache.org>.

jedcunningham commented on a change in pull request #17666:
URL: https://github.com/apache/airflow/pull/17666#discussion_r690778830



##########
File path: chart/values.schema.json
##########
@@ -1818,6 +1818,12 @@
                             ],
                             "default": null
                         }
+                        },
+                        "loadBalancerSourceRanges": {
+                            "description": "Webserver Service loadBalancerSourceRanges.",
+                            "type": "array",
+                            "default": []

Review comment:
       ```suggestion
                               "default": [],
                               "examples": [
                                   "143.231.0.0/16"
                               ]
   ```

##########
File path: chart/templates/webserver/webserver-service.yaml
##########
@@ -51,3 +51,9 @@ spec:
   {{- if .Values.webserver.service.loadBalancerIP }}
   loadBalancerIP: {{ .Values.webserver.service.loadBalancerIP }}
   {{- end }}
+  {{- if .Values.service.loadBalancerSourceRanges }}
+  loadBalancerSourceRanges:
+  {{- range $cidr := .Values.service.loadBalancerSourceRanges }}
+    - {{ $cidr }}
+  {{- end }}

Review comment:
       ```suggestion
     {{- toYaml .Values.service.loadBalancerSourceRanges | nindent 4 }}
   ```
   
   I think this is cleaner?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #17666:
URL: https://github.com/apache/airflow/pull/17666#issuecomment-900620417

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

Posted by GitBox <gi...@apache.org>.

jedcunningham commented on pull request #17666:
URL: https://github.com/apache/airflow/pull/17666#issuecomment-902046953


   Looks like static checks are failing. I'd also suggest that you [set up the pre-commit hooks](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks), they help catch these issues early 👍.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org